Add ability to pause and resume all Timers #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make `TimerManager` public to allow reference to current instance to be made - Add `PauseAllTimers` method to pause all `Timer` instances, following `CancelAllTimers` example - Add `ResumeAllTimers` method to resume all `Timer` instances, following `CancelAllTimers` example
|
Turns out there was a better way to go about this, which is to follow the example of
|
|
Oh god, I'm so sorry, I somehow had email notifications turned off! Reviewing now. |
|
Thanks for merging, @akbiggs! |
|
Sorry it took so long!!!!!!!!!! |
|
Not a problem, just happy to be able to contribute back to the project 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there, thanks for your very useful library!
I have a need to be able to pause and resume all active timers in my project when an in-game pause menu is toggled, so I have extended
TimerManagerin the following way to support this:TimerManagerpublic to allow reference to current instance to be madePauseAllTimersmethod to pause allTimerinstances, followingCancelAllTimersexampleResumeAllTimersmethod to resume allTimerinstances, followingCancelAllTimersexampleI am aware from #1 that you'd kept
TimerManagerprivate deliberately, but I don't believe that this change should affect how it is used, i.e. instantiated automatically when the first newTimerinstance is created. If, however, there is a better way to achieve pausing and resuming all timers at once, please let me know!