Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change image rendering in Livebook #161

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Change image rendering in Livebook #161

merged 1 commit into from
Aug 7, 2024

Conversation

akash-akya
Copy link
Owner

@akash-akya akash-akya commented Jul 26, 2024

@kipcole9 I am thinking of removing the image metadata tabs while rendering the Image in the livebook and show it below the image instead.

This is for two reasons:

  • Tabs does not seem to play nice other components like grid
  • I often want to have quick glance over these metadata and want to avoid manually switching tabs on re-evaluate

The changes make it look like this, wdyt?

Screenshot 2024-07-27 at 12 25 08 AM

@akash-akya
Copy link
Owner Author

@kipcole9 ping. In case you missed :)

@kipcole9
Copy link
Contributor

kipcole9 commented Aug 6, 2024

@akash-akya sorry for the slow response. Yes, I think this is a good call - I haven't found any particular value in the second tab. And using images in a grid is really common.

@akash-akya akash-akya merged commit bac44a7 into master Aug 7, 2024
20 checks passed
@akash-akya akash-akya deleted the dev branch August 7, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants