Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify APIs #141

Merged
merged 2 commits into from
Aug 16, 2021
Merged

modify APIs #141

merged 2 commits into from
Aug 16, 2021

Conversation

marihachi
Copy link
Contributor

@marihachi marihachi commented Aug 14, 2021

What

For #111

  • Parser APIの一新
  • Analyze APIの廃止、意味解析処理はParser APIにパーサプラグインとして統合
  • 旧parse APIの互換性テストの追加
  • テストのAPI呼び出し処理の更新

これまでのparse関数の互換性は維持できそう。

Why

Additional info (optional)

* replaces the parser api.
* move the analyze api as the parser plugin into the parser api.
@codecov
Copy link

codecov bot commented Aug 14, 2021

Codecov Report

Merging #141 (40e90a4) into master (c77ebdf) will increase coverage by 0.12%.
The diff coverage is 92.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #141      +/-   ##
==========================================
+ Coverage   72.11%   72.24%   +0.12%     
==========================================
  Files          16       15       -1     
  Lines        2109     2126      +17     
  Branches      304      307       +3     
==========================================
+ Hits         1521     1536      +15     
- Misses        586      588       +2     
  Partials        2        2              
Impacted Files Coverage Δ
src/parser/index.ts 93.10% <92.00%> (+1.10%) ⬆️
src/index.ts 100.00% <100.00%> (ø)
src/parser/plugins/set-attribute.ts 82.92% <100.00%> (ø)
src/parser/plugins/validate-keyword.ts 89.74% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c77ebdf...40e90a4. Read the comment docs.

@syuilo
Copy link
Collaborator

syuilo commented Aug 15, 2021

今日〜明日で見る

@syuilo syuilo merged commit 190c304 into master Aug 16, 2021
@syuilo syuilo deleted the work/modify-parser-api branch August 16, 2021 08:59
@syuilo
Copy link
Collaborator

syuilo commented Aug 16, 2021

👍👍👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants