Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IllegalArgumentException when createBitmap #2351

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

tonyfu511
Copy link
Contributor

IllegalArgumentException is thrown when creating bitmap in ensureSoftwareRenderingBitmap() if the getIntrinsicWidth or getIntrinsicHeight returns -1. So, returns when renderWidth or renderHeight is negative to avoid the crash

Fixes #2350

IllegalArgumentException is thrown when creating bitmap in ensureSoftwareRenderingBitmap() if the getIntrinsicWidth or getIntrinsicHeight returns -1. So, returns when renderWidth or renderHeight is negative
@github-actions
Copy link

github-actions bot commented Aug 1, 2023

Snapshot Tests
API 23: Report Diff
API 31: Report Diff

@gpeal gpeal merged commit 0014ef6 into airbnb:master Aug 1, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Width and height validations don't cover all possible values
3 participants