fixed: Using Text Delegate and scaletype then the textfield wont posi… #1583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fixed some text layout issues I was having as well. If we get this or a similar PR passing on the master branch, is it likely to get merged? |
I try it |
merge code form fork master
# Conflicts: # LottieSample/src/main/kotlin/com/airbnb/lottie/samples/PreviewItemView.kt # LottieSample/src/main/kotlin/com/airbnb/lottie/samples/TestColorFilterActivity.java # LottieSample/src/main/kotlin/com/airbnb/lottie/samples/views/ControlBarItemToggleView.kt
|
@pikaMouse I hope you don't mind, I included this commit along with some other dynamic text layout fixes in PR #1635 |
Of course not |
gpeal
pushed a commit
that referenced
this pull request
Oct 2, 2020
Close #1183. Close #1310. This has a couple of related bugfixes. Fix the scale/positioning of the text relative to the parent (from PR #1583, thanks @pikaMouse) Include text tracking values in the line width used for text alignment Scale the text tracking values based on the font size rather than the parent size (parent size adjustment is already handled when we're calculating tracking values) Include all bytes for multibyte characters when calculating canvas offsets for characters.
gpeal
pushed a commit
that referenced
this pull request
Oct 4, 2020
Close #1183. Close #1310. This has a couple of related bugfixes. Fix the scale/positioning of the text relative to the parent (from PR #1583, thanks @pikaMouse) Include text tracking values in the line width used for text alignment Scale the text tracking values based on the font size rather than the parent size (parent size adjustment is already handled when we're calculating tracking values) Include all bytes for multibyte characters when calculating canvas offsets for characters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had the same issue as #1310. When I use TextDelegate to change the text in my animation and I use a scaletype for example "Center" then the textfield doesn't respect the scaling & positioning of the LottieAnimationView.At present，I've fixed it with using "concat" rather than "setMatrix" before draw something in the canvas. The difference between them as follow：