Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added issue-repro module #1351

Merged
merged 2 commits into from
Aug 11, 2019
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Added issue-repro module
  • Loading branch information
Gabriel Peal committed Aug 10, 2019
commit b8aea7ba838f82b8ae5fe2574b5652203ce6af5f
7 changes: 5 additions & 2 deletions .github/ISSUE_TEMPLATE/non-rendering-bug.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,11 @@ assignees: ''
** If you don't use this template, your issue will be closed **

**Checklist**
1. Create a sample project that reproduces your bug.
1. Attach your project as a zip file.
1. Fork this repository into your account.
1. Reproduce your issue in the issue-repro module. Issues without a repro in the issue-repro
module may be auto-closed.

**Link to fork with a repro in the issue-repro module**

**Describe the bug**

Expand Down
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/rendering-bug.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
name: Rendering Bug
about: Lottie isn't rendering my animation correctly
about: Lottie isn't visually rendering my animation correctly
title: ''
labels: Rendering bug
assignees: ''
Expand Down
21 changes: 21 additions & 0 deletions issue-repro/build.gradle
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
apply plugin: 'com.android.application'
apply plugin: 'kotlin-android'
apply plugin: 'kotlin-android-extensions'

android {
compileSdkVersion 29
buildToolsVersion "29.0.0"
defaultConfig {
applicationId "com.airbnb.lottie.issues"
minSdkVersion 16
targetSdkVersion 29
versionCode 1
versionName "1.0"
testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
}
}

dependencies {
implementation project(':lottie')
implementation("androidx.appcompat:appcompat:1.1.0-rc01")
}
16 changes: 16 additions & 0 deletions issue-repro/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
package="com.airbnb.lottie.issues">

<application
android:icon="@mipmap/ic_launcher"
android:label="@string/app_name"
android:theme="@style/Theme.AppCompat.Light.NoActionBar">
<activity android:name=".MainActivity">
<intent-filter>
<action android:name="android.intent.action.MAIN" />
<category android:name="android.intent.category.LAUNCHER" />
</intent-filter>
</activity>
</application>
</manifest>
16 changes: 16 additions & 0 deletions issue-repro/src/main/java/com/airbnb/lottie/issues/MainActivity.kt
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
package com.airbnb.lottie.issues

import android.content.Intent
import android.os.Bundle
import androidx.appcompat.app.AppCompatActivity
import androidx.core.app.ActivityOptionsCompat
import com.airbnb.lottie.issues.R
import kotlinx.android.synthetic.main.activity_main.*

class MainActivity : AppCompatActivity() {
override fun onCreate(savedInstanceState: Bundle?) {
super.onCreate(savedInstanceState)
setContentView(R.layout.activity_main)
// Reproduce any issues here.
}
}
8 changes: 8 additions & 0 deletions issue-repro/src/main/res/layout/activity_main.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
<?xml version="1.0" encoding="utf-8"?>
<FrameLayout xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:app="http://schemas.android.com/apk/res-auto"
android:layout_width="match_parent"
android:layout_height="match_parent">


</FrameLayout>
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions issue-repro/src/main/res/values/strings.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
<resources>
<string name="app_name">Lottie Issue</string>
</resources>
2 changes: 1 addition & 1 deletion settings.gradle
Original file line number Diff line number Diff line change
@@ -1 +1 @@
include ':LottieSample', ':lottie'
include ':LottieSample', ':lottie', ':issue-repro'