-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #189: Add initial support for networks #207
Conversation
Seems that tests are broken by unrelated reasons. |
Hi @apatrushev, check flake8 |
Codecov Report
@@ Coverage Diff @@
## master #207 +/- ##
=========================================
+ Coverage 83.23% 83.8% +0.56%
=========================================
Files 18 19 +1
Lines 853 883 +30
=========================================
+ Hits 710 740 +30
Misses 143 143
Continue to review full report at Codecov.
|
Sorry for such long story in this PR - I was not sure about tests organization and how to run them locally. Now everything should be fine. |
thanks @apatrushev ! do you mind adding the docstrings for each method? Even something short is fine. |
also can you add a test for |
Sorry, I think that current abstraction is very low level and comments will be useless. Almost all methods in this library are thin wrappers around Docker Engine API calls and best docstring is a link to Docker Engine API. I will add tests for [dis]connect methods. |
Ok. I added the tests for [dis]connect network methods. Now tests definitely was broken by unrelated reasons. |
Thanks @apatrushev ! |
What do these changes do?
Add initial and thin networks support (same as volumes).
Are there changes in behavior for the user?
New attribute available in docker object -
networks
.Related issue number
#189
Checklist
CONTRIBUTORS.txt
changes
folder<issue_id>.<type>
for example (588.bug)issue_id
change it to the pr id after creating the pr.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.