Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Syntax check fails to check invalid characters not presenting at the beginning of the triggers #82

Closed
htdinh opened this issue Feb 15, 2017 · 1 comment
Closed

Syntax check fails to check invalid characters not presenting at the beginning of the triggers #82

htdinh opened this issue Feb 15, 2017 · 1 comment

Comments

@htdinh
Copy link
Contributor

htdinh commented Feb 15, 2017

Check syntax can throw syntax exception at this template:

+ $hello
- hi

But not this

+ hello$
- hi
@htdinh
Copy link
Contributor Author

htdinh commented Feb 15, 2017

The solution is check syntax use match regex but it should use search. More explanation is in Python doc here.

htdinh pushed a commit to htdinh/rivescript-python that referenced this issue Feb 24, 2017
aichaos#82 Allow uppercase at object and minor indent fix
e604ff3
kirsle added a commit that referenced this issue Feb 24, 2017
@kirsle
Merge pull request #83 from Dinh-Hung-Tu/82
ab3b255 
Issue #82 solution
@kirsle kirsle closed this as completed Feb 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kirsle @htdinh