Support Sass 3.5+ (while dropping support for Sass < 3.3) #26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sass 3.5 introduced support for bracketed lists (sass/sass@be02da0), which changed the method signature of
Sass::Script::Value::List#initialize
to accept theseparator
as a keyword argument rather than as the second positional argument.This changes our implementation to support both the pre- and post-3.5 world.
While we're at it, it's time to drop support for Sass < 3.3:
3.3.x was also last released in 2014 (2014-08-01 as 3.3.14), but supporting the last 3 major versions (Sass only started following Semver from 3.5 onwards) seems like a reasonable amount.