Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: upgrade to rpt2 0.32.1 to fix configPlugin declarationMap issue #86

Merged
merged 1 commit into from
Jun 11, 2022

Conversation

agilgur5
Copy link
Owner

Summary

Upgrade to rpt2 0.32.0+ to fix issues with using it as a configPlugin while enabling declarationMaps

Details

…ssue

- Per b14060c, I ran into a bug in rpt2 when using it as a `configPlugin` and enabling declarationMaps
  - that bug was actually due to some code _I_ wrote in rpt2 and an edge case I didn't know existed (`configPlugin` usage means Rollup has no `output`)
  - so I eventually fixed it myself too
  - and in the past month I stepped up to help maintain rpt2 and fixed a ton of issues and improved lots of things per the release notes :)

- since declarationMaps now work while using as a `configPlugin`, remove the workaround `tsconfig.rollup.json`
@agilgur5 agilgur5 added kind: internal Changes only affect the internals and not the API or usage scope: dependencies Pull requests that update a dependency file labels Jun 11, 2022
Copy link
Owner Author

@agilgur5 agilgur5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Confirmed that the build still runs (and CI passes too). package-lock.json gets to shrink a bit after ezolenko/rollup-plugin-typescript2#326 too!

@agilgur5 agilgur5 merged commit 5771d33 into main Jun 11, 2022
@agilgur5 agilgur5 deleted the deps-upgrade-rpt2-configplugin-declarationMap branch June 11, 2022 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: internal Changes only affect the internals and not the API or usage scope: dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant