Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task/clean up app.ts #319

Merged
merged 3 commits into from
Dec 17, 2022
Merged

Task/clean up app.ts #319

merged 3 commits into from
Dec 17, 2022

Conversation

ageddesi
Copy link
Owner

Describe your changes

  • Cleaned up the execution order in the app.ts file for plugins.
  • Moved complex setup for sentry out into its own file.
  • Added new additional .env variables for toggling off / on features.

Link to issue this resolves

Fixes: #306

@what-the-diff
Copy link

what-the-diff bot commented Dec 13, 2022

  • Added a new file src/setup/sentry.ts
  • Updated app.ts to use the sentry setup function if ENABLE_SENTRY is true in .env

@ageddesi ageddesi merged commit 7d0725b into dev Dec 17, 2022
@ageddesi ageddesi deleted the task/clean-up-app.ts branch December 17, 2022 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@computamike computamike Awaiting requested review from computamike

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Morgan reporting (and possibly other middlwares are not working)
1 participant
@ageddesi