Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Open API comments and tests for time zones #141

Merged
merged 5 commits into from
Oct 3, 2022

Conversation

devrrior
Copy link
Contributor

@devrrior devrrior commented Oct 3, 2022

I added OpenAPI comments and tests for the time zones module. Also I changed URL from /time_zone/ to /time-zone/, from my point of view is a better practice.

Issues related #126 #127

@ageddesi ageddesi merged commit da5eca2 into ageddesi:v.0.13.0 Oct 3, 2022
@ageddesi
Copy link
Owner

ageddesi commented Oct 3, 2022

@all-contributors please add @devrrior for doc

Thank you @devrrior for the contribution, Happy Hacktoberfest. 👍

@allcontributors
Copy link
Contributor

@ageddesi

@devrrior already contributed before to doc

@devrrior
Copy link
Contributor Author

devrrior commented Oct 3, 2022

@all-contributors please add @devrrior for doc

Thank you @devrrior for the contribution, Happy Hacktoberfest. 👍

No problem, it's a pleasure. Don't forget to close this issue (tests) #127 as well

@allcontributors
Copy link
Contributor

@devrrior

I've put up a pull request to add @devrrior! 🎉

@devrrior devrrior deleted the time-zones branch October 19, 2022 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants