Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add path to service #89

Merged
merged 2 commits into from
Aug 28, 2023
Merged

Add path to service #89

merged 2 commits into from
Aug 28, 2023

Conversation

ygelfand
Copy link
Contributor

cloudflare allows for path-based matching, this would allow exposing/pointing just specific paths to specific services

@adyanth
Copy link
Owner

adyanth commented Jun 27, 2023

Thanks for the PR!

What happens when the path is empty? The docs don't make that clear, but should it not be "/" by default?

@ygelfand
Copy link
Contributor Author

its a regex, so you'd have to do /.* or similar to have default behavior. default behavior is to not pass it (and since its set to omitempty, it simply leaves it out of the config), and in turn the cloudflare side just doesn't include path as part of matching.

@ygelfand
Copy link
Contributor Author

bump

@adyanth adyanth merged commit e01ecd2 into adyanth:main Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants