Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow user to set OPENLIBERTY_SHA #4639

Merged
merged 1 commit into from
Jun 21, 2023
Merged

Allow user to set OPENLIBERTY_SHA #4639

merged 1 commit into from
Jun 21, 2023

Conversation

llxia
Copy link
Contributor

@llxia llxia commented Jun 21, 2023

No description provided.

@llxia
Copy link
Contributor Author

llxia commented Jun 21, 2023

Grinder
Grinder

@llxia llxia marked this pull request as ready for review June 21, 2023 19:59
@llxia llxia requested review from LongyuZhang, karianna and renfeiw and removed request for karianna June 21, 2023 19:59
renfeiw
renfeiw approved these changes Jun 21, 2023
View reviewed changes
Copy link
Contributor

@renfeiw renfeiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

LongyuZhang
LongyuZhang approved these changes Jun 21, 2023
View reviewed changes
Copy link
Contributor

@LongyuZhang LongyuZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LongyuZhang LongyuZhang merged commit 9217c7e into adoptium:master Jun 21, 2023
2 checks passed
smlambert
smlambert reviewed Jun 22, 2023
View reviewed changes
Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is likely a dangerous precedent (for parameter bloat). Wonder if there is a way to utilize test.properties or APPLICATION_OPTIONS for this type of finessing.

@llxia
Copy link
Contributor Author

llxia commented Jun 22, 2023

I agree, we should look into it and find a better way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smlambert smlambert smlambert left review comments

@renfeiw renfeiw renfeiw approved these changes

@LongyuZhang LongyuZhang LongyuZhang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@llxia @smlambert @renfeiw @LongyuZhang