Exclude overrunning SPARCV9 tests #4631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamfarley
force-pushed
the
exclude_tests_on_sparcv9
branch
from
ada94d2
to
14fc2f3
Compare
karianna
approved these changes
Jun 20, 2023
sxa
reviewed
Jun 20, 2023
There was a problem hiding this comment.
@adamfarley Can you adjust the title of the PR+Commit message to say "SPARC" rather than "Spark" please
|
Sure thing Stewart. Will remember that for the future. Update: Done. |
adamfarley
changed the title
These tests take between 10 mins and 2 hours to run, so I'm excluding them to avoid timeouts. Anyone who wants them put back in should feel free to propose faster machines, make the case for 5 extra hours of runtime per execution, or find a solution for the cause of the timeouts. Signed-off-by: Adam Farley <[email protected]>
adamfarley
force-pushed
the
exclude_tests_on_sparcv9
branch
from
14fc2f3
to
b4c9834
Compare
sxa
approved these changes
Jun 20, 2023
There was a problem hiding this comment.
I'm happy with this but it would be good to have an explicit 👍🏻 on this from @smlambert too before merging.
smlambert
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests take between 10 mins and 2 hours to run, so I'm excluding them to avoid timeouts. Anyone who wants them put back in should feel free to propose faster machines, make the case for 5 extra hours of runtime per execution, or find a solution for the cause of the timeouts.