-
-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update jck material versions #4601
Conversation
b87eceb
to
8b8ebc8
Compare
Just a note : IBM internal tck repositories for 8 and 11 have to be updated with 8d and 11a materials before this PR can be delivered. |
Is the expection that you'll be able to do that soon? Obviously we'll want this for the next release in July. |
@Mesbah-Alam I'm having problems testing this PR because it looks like the harness is no longer starting the agent correctly. Having tried a revert of your PR #4512 it runs correctly. Can you take a look at this please and see if you can fix the missing agent startup? |
@sxa , which version of tck are you trying to run? Are you seeing any particular errors? |
Please discuss details in a private DM. |
LGTM. On the basis that this PR works as expected I'm going to take this out of draft. Your other PR seems good too. |
Signed-off-by: Stewart X Addison <[email protected]>
I will tag AQAvit repos prior to merging this PR, in case others who may be using our scripts have a recent tag to fall back to while they update to the latest 8d/11a materials. |
@Mesbah-Alam is this ok for your internal requirements? I'd like to get this merged today if feasible in order to allow us to be able to run the tests over the weekend. |
Re #4601 (comment) : Unfortunately, I am occupied with some other work today. If this is merged now, it will break the internal tck builds. So, please co-ordinate with @llxia and see if the internal 8 and 11 repo's could be updated today by someone else. Other option is, as Shelley suggested, use a tag. Otherwise, please wait till next week and I will update the internal 8 and 11 repos. |
We will plan to merge it next week, and I will post an announcement to the Slack channel to alert any others who may be affected by it. |
This PR looks good. Tested with
Please note, the 'main' branch of the internal repos are yet to be updated with 8d and 11a. I ran my test off of my branch. I will update the 'main' branch once this PR is merged after the tagging is done (Re: #4601 (comment)). |
@smlambert Did you get a suitable tag in place? If so it sounds like we can get this in and run a test with all the fixes we have at once against the latest material :-) |
People can use aqa-tests tag: |
Updated Internal tck repos : 8 -> 8d, 11->11a. |
New versions of the repositories have been created for 8 and 11. This adjusts the test harness to compensate.
Draft while it undergoes testing and iterative updates.