Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexclude com/sun/jdi/RedefineCrossEvent.java on JDK8 #4280

Merged
merged 1 commit into from
Jan 26, 2023

Conversation

zzambers
Copy link
Contributor

Test com/sun/jdi/RedefineCrossEvent.java should no longer be excluded on JDK 8. It was fixed by:
https://bugs.openjdk.org/browse/JDK-8279669

@smlambert
Copy link
Contributor

@zzambers - Can you sign the ECA? https://adoptium.net/docs/eca-sign-off/

@CarmenDelgadoEclipse - this is an example where a Red Hatter (who would be covered under the Red Hat member agreement and should not need to sign the ECA, still needs to in order to pass the ECA validation check). What action could be taken to correct this for others in a similar situation? Does zzambers need to add something to their Github account to indicate they are a Red Hat employee?

@smlambert
Copy link
Contributor

smlambert commented Jan 26, 2023

Verifying this PR (and that the test runs and passes) in following test runs:
jdk17 x86-64_linux: https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/6479
jdk17 aarch64_mac: https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/6480
jdk17 x86-64_windows: https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/6481

Ignore those, wrong JDK_VERSION, see JDK8
https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/6483

@zzambers
Copy link
Contributor Author

@smlambert Signed

failure on mac looks like infra problem

@smlambert
Copy link
Contributor

Failure on mac was a reviewer error, as we do not have aarch64 mac builds for JDK8, x86-64_mac run looks fine.

Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @zzambers !

@sophia-guo sophia-guo merged commit 7fc91a2 into adoptium:master Jan 26, 2023
@zzambers
Copy link
Contributor Author

@smlambert @sophia-guo thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants