Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow AUTO_DETECT to be set in template #1686

Merged
merged 1 commit into from
Mar 19, 2020
Merged

Allow AUTO_DETECT to be set in template #1686

merged 1 commit into from
Mar 19, 2020

Conversation

AdamBrousseau
Copy link
Contributor

Having the ability to set AUTO_DETECT to false, will allow
us to generate Valhalla builds with this value set to false
by default. Therefore not having to pass it to the test job.
Since the Valhalla test jobs will be separate, this will
not affect other jobs. Default value will still be true.

Related eclipse-openj9/openj9#4719

Signed-off-by: Adam Brousseau [email protected]

@AdamBrousseau
Allow AUTO_DETECT to be set in template
ce2dde9 
Having the ability to set AUTO_DETECT to false, will allow
us to generate Valhalla builds with this value set to false
by default. Therefore not having to pass it to the test job.
Since the Valhalla test jobs will be separate, this will
not affect other jobs. Default value will still be true.

Related eclipse-openj9/openj9#4719

Signed-off-by: Adam Brousseau <[email protected]>
@AdamBrousseau
Copy link
Contributor Author

Note: This will require script approval at all the servers
I have added the bool param and defaulted it to true on the OpenJ9 and internal (hyc-runtimes) test auto gen jobs.
I have tested this internally and generated the job "Test_openjdkvalhalla_j9_sanity.functional_x86-64_linux_valhalla_Personal". I am undecided if having the word valhalla in the name twice is worth changing more code on my side for, but it is unrelated to this change.

@karianna karianna added the bug label Mar 19, 2020
@karianna karianna added this to the March 2020 milestone Mar 19, 2020
llxia
llxia approved these changes Mar 19, 2020
View reviewed changes
Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@llxia llxia merged commit 94c851a into adoptium:master Mar 19, 2020
@AdamBrousseau
Copy link
Contributor Author

Approval for OpenJ9 Jenkins
https://bugs.eclipse.org/bugs/show_bug.cgi?id=551332

@llxia
Copy link
Contributor

llxia commented Mar 20, 2020

Please also make sure the script is approved at Adopt Jenkins. Thanks.

@AdamBrousseau
Copy link
Contributor Author

I don't have access to Adopt. I assumed you did :D
If not maybe @ShelleyLambert .

@AdamBrousseau
Copy link
Contributor Author

Since it's passed today, I assume the approval has been done.
https://ci.adoptopenjdk.net/view/all/job/Test_Job_Auto_Gen/

@smlambert
Copy link
Contributor

Yes, I should have added a comment that I ran and approved it at Adopt already. :)

@AdamBrousseau
Copy link
Contributor Author

Thanks Shelley

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@llxia llxia llxia approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
March 2020
Development

Successfully merging this pull request may close these issues.
4 participants
@AdamBrousseau @llxia @smlambert @karianna