Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace references of openjdk-systemtest with aqa-systemtest #115

Merged
merged 1 commit into from
May 12, 2021
Merged

Replace references of openjdk-systemtest with aqa-systemtest #115

merged 1 commit into from
May 12, 2021

Conversation

Mesbah-Alam
Copy link
Contributor

@Mesbah-Alam
Copy link
Contributor Author

Works fine in non-parallel build. Sanity.jck green: Test_grinder/job/Grinder/14986/

@Mesbah-Alam Mesbah-Alam self-assigned this Apr 27, 2021
@karianna karianna added this to the April 2021 milestone Apr 28, 2021
karianna
karianna approved these changes Apr 28, 2021
View reviewed changes
Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - take out of draft?

@llxia
Copy link
Contributor

llxia commented Apr 30, 2021 •
edited
Loading

Works fine in non-parallel build

To test parallel builds, please regenerate Grinder_testlist_*. Or delete them if you do not need the history. Some Grinder_testlist_* job is generated with Lightweight checkout set to true, so it uses Adopt master for pipeline changes.

@Mesbah-Alam Mesbah-Alam force-pushed the remove-reference-of-openjdk-systemtest branch from 9c8bdef to 2769888 Compare May 7, 2021 18:44
@karianna karianna modified the milestones: April 2021, May 2021 May 10, 2021
@Mesbah-Alam Mesbah-Alam marked this pull request as ready for review May 10, 2021 16:42
@Mesbah-Alam
Copy link
Contributor Author

Tests:

  • sanity.jck (with parallel = 6) - Grinder/15334/ - green
  • extended.system (with parallel = 4) - Grinder/15328/ - green

This was referenced May 10, 2021
Merged
Merged
@llxia
Copy link
Contributor

llxia commented May 10, 2021

Please note all 4 PRs have to merged together:
#115
adoptium/aqa-systemtest#425
adoptium/openj9-systemtest#129
adoptium/aqa-tests#2542

llxia
llxia approved these changes May 10, 2021
View reviewed changes
Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mesbah-Alam Mesbah-Alam mentioned this pull request May 10, 2021
Merged
@karianna
Copy link
Contributor

I think adoptium/openj9-systemtest#129 is meant to be adoptium/openj9-systemtest#132

Also, putting this into draft so it's not merged by accident until we're ready.

@karianna karianna marked this pull request as draft May 11, 2021 12:46
@llxia llxia requested a review from smlambert May 12, 2021 14:34
smlambert
smlambert approved these changes May 12, 2021
View reviewed changes
Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aside from minor spelling in comment, LGTM

stf.build/include/top.xml Outdated
@@ -322,7 +322,7 @@ limitations under the License.
</target>

<!--
Some tests may require test.debugging requires tools.jar for building (e.g. test.debugging in openjdk-systemtests).
Some tests may require test.debugging requires tools.jar for building (e.g. test.debugging in aqa-systemtests).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

predates this change, but there is no 's' on the end of aqa-systemtest

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting. Fixed!

@Mesbah-Alam Mesbah-Alam force-pushed the remove-reference-of-openjdk-systemtest branch from 2769888 to 61b1de4 Compare May 12, 2021 15:40
@Mesbah-Alam Mesbah-Alam marked this pull request as ready for review May 12, 2021 16:15
@smlambert smlambert merged commit 1a1f7a1 into adoptium:master May 12, 2021
@Mesbah-Alam Mesbah-Alam deleted the remove-reference-of-openjdk-systemtest branch May 12, 2021 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karianna karianna karianna approved these changes

@smlambert smlambert smlambert approved these changes

@llxia llxia llxia approved these changes

Assignees

@Mesbah-Alam Mesbah-Alam

Labels
enhancement
Projects
None yet
Milestone
May 2021
Development

Successfully merging this pull request may close these issues.
4 participants
@Mesbah-Alam @llxia @karianna @smlambert