Skip to content

Commit

Permalink
doc: ensure collaborators validate commits
Browse files Browse the repository at this point in the history
This should be done every time a collaborator pushes a commit.

PR-URL: nodejs#16162
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
  • Loading branch information
bmeck authored and jasnell committed Oct 13, 2017
1 parent 4faa231 commit eb3fee1
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions COLLABORATOR_GUIDE.md
Original file line number Diff line number Diff line change
Expand Up @@ -517,6 +517,13 @@ Run tests (`make -j4 test` or `vcbuild test`). Even though there was a
successful continuous integration run, other changes may have landed on master
since then, so running the tests one last time locally is a good practice.

Validate that the commit message is properly formatted using
[core-validate-commit](https://github.com/evanlucas/core-validate-commit).

```text
$ git rev-list upstream/master...HEAD | xargs core-validate-commit
```

Time to push it:

```text
Expand Down

0 comments on commit eb3fee1

Please sign in to comment.