Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate NumPyClient #2563

Merged
merged 23 commits into from
Feb 1, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
304b196
added deprecated warning back
jafermarq Nov 6, 2023
fa68a97
Merge branch 'main' into deprecate-numpyclient-docs-update
jafermarq Dec 18, 2023
099f6cf
Merge branch 'main' into deprecate-numpyclient-docs-update
jafermarq Dec 19, 2023
b5280f8
updating docs
jafermarq Dec 19, 2023
dfd1ba4
format
jafermarq Dec 19, 2023
24cf3a0
better
jafermarq Dec 20, 2023
f0ac956
howto ssl
jafermarq Dec 20, 2023
25063a5
to changelog
jafermarq Dec 20, 2023
22ad72e
Merge branch 'main' into deprecate-numpyclient-docs-update
jafermarq Jan 4, 2024
07d188d
Merge branch 'main' into deprecate-numpyclient-docs-update
jafermarq Jan 18, 2024
a62a4e0
Merge branch 'main' into deprecate-numpyclient-docs-update
jafermarq Jan 29, 2024
bb6b253
using new deprecation logger func
jafermarq Jan 29, 2024
d06ddd2
better docs
jafermarq Jan 29, 2024
4093fd4
revert
jafermarq Jan 29, 2024
d1fa553
Merge branch 'main' into deprecate-numpyclient-docs-update
jafermarq Jan 29, 2024
0715990
format
jafermarq Jan 29, 2024
15fb156
Merge branch 'main' into deprecate-numpyclient-docs-update
danieljanes Jan 30, 2024
cae8931
Merge branch 'main' into deprecate-numpyclient-docs-update
jafermarq Jan 30, 2024
e61242d
updated .po files
jafermarq Jan 30, 2024
1e9f496
Merge branch 'main' into deprecate-numpyclient-docs-update
danieljanes Jan 30, 2024
b646b43
removed redundancies
jafermarq Jan 31, 2024
7fcf83e
Merge branch 'main' into deprecate-numpyclient-docs-update
danieljanes Feb 1, 2024
4812ea7
Merge branch 'main' into deprecate-numpyclient-docs-update
danieljanes Feb 1, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 10 additions & 14 deletions doc/locales/fr/LC_MESSAGES/framework-docs.po
Original file line number Diff line number Diff line change
Expand Up @@ -3239,14 +3239,14 @@ msgid ""
"All that's left to do it to define a function that loads both model and "
"data, creates a :code:`CifarClient`, and starts this client. You load "
"your data and model by using :code:`cifar.py`. Start :code:`CifarClient` "
"with the function :code:`fl.client.start_numpy_client()` by pointing it "
"with the function :code:`fl.client.start_client()` by pointing it "
"at the same IP adress we used in :code:`server.py`:"
msgstr ""
"Il ne reste plus qu'à définir une fonction qui charge le modèle et les "
"données, crée un :code:`CifarClient` et démarre ce client. Tu charges tes"
" données et ton modèle en utilisant :code:`cifar.py`. Démarre "
":code:`CifarClient` avec la fonction "
":code:`fl.client.start_numpy_client()` en la faisant pointer sur la même "
":code:`fl.client.start_client()` en la faisant pointer sur la même "
"adresse IP que celle que nous avons utilisée dans :code:`server.py` :"

#: ../../source/example-pytorch-from-centralized-to-federated.rst:307
Expand Down Expand Up @@ -6137,8 +6137,8 @@ msgstr ""
msgid ""
"The :code:`VirtualClientEngine` schedules, launches and manages `virtual`"
" clients. These clients are identical to `non-virtual` clients (i.e. the "
"ones you launch via the command `flwr.client.start_numpy_client <ref-api-"
"flwr.html#start-numpy-client>`_) in the sense that they can be configure "
"ones you launch via the command `flwr.client.start_client <ref-api-"
"flwr.html#start-client>`_) in the sense that they can be configure "
"by creating a class inheriting, for example, from "
"`flwr.client.NumPyClient <ref-api-flwr.html#flwr.client.NumPyClient>`_ "
"and therefore behave in an identical way. In addition to that, clients "
Expand Down Expand Up @@ -14091,17 +14091,15 @@ msgstr ""
#: ../../source/tutorial-quickstart-scikitlearn.rst:147
msgid ""
"That's it for the client. We only have to implement :code:`Client` or "
":code:`NumPyClient` and call :code:`fl.client.start_client()` or "
":code:`fl.client.start_numpy_client()`. The string "
":code:`NumPyClient` and call :code:`fl.client.start_client()`. The string "
":code:`\"0.0.0.0:8080\"` tells the client which server to connect to. In "
"our case we can run the server and the client on the same machine, "
"therefore we use :code:`\"0.0.0.0:8080\"`. If we run a truly federated "
"workload with the server and clients running on different machines, all "
"that needs to change is the :code:`server_address` we pass to the client."
msgstr ""
"C'est tout pour le client. Il nous suffit d'implémenter :code:`Client` ou"
" :code:`NumPyClient` et d'appeler :code:`fl.client.start_client()` ou "
":code:`fl.client.start_numpy_client()`. La chaîne :code:`\"0.0.0:8080\"` "
" :code:`NumPyClient` et d'appeler :code:`fl.client.start_client()`. La chaîne :code:`\"0.0.0:8080\"` "
"indique au client à quel serveur se connecter. Dans notre cas, nous "
"pouvons exécuter le serveur et le client sur la même machine, c'est "
"pourquoi nous utilisons :code:`\"0.0.0:8080\"`. Si nous exécutons une "
Expand Down Expand Up @@ -14325,17 +14323,15 @@ msgstr ""
#: ../../source/tutorial-quickstart-tensorflow.rst:87
msgid ""
"That's it for the client. We only have to implement :code:`Client` or "
":code:`NumPyClient` and call :code:`fl.client.start_client()` or "
":code:`fl.client.start_numpy_client()`. The string :code:`\"[::]:8080\"` "
":code:`NumPyClient` and call :code:`fl.client.start_client()`. The string :code:`\"[::]:8080\"` "
"tells the client which server to connect to. In our case we can run the "
"server and the client on the same machine, therefore we use "
":code:`\"[::]:8080\"`. If we run a truly federated workload with the "
"server and clients running on different machines, all that needs to "
"change is the :code:`server_address` we point the client at."
msgstr ""
"C'est tout pour le client. Il nous suffit d'implémenter :code:`Client` ou"
" :code:`NumPyClient` et d'appeler :code:`fl.client.start_client()` ou "
":code:`fl.client.start_numpy_client()`. La chaîne :code:`\"[: :]:8080\"` "
" :code:`NumPyClient` et d'appeler :code:`fl.client.start_client()`. La chaîne :code:`\"[: :]:8080\"` "
"indique au client à quel serveur se connecter. Dans notre cas, nous "
"pouvons exécuter le serveur et le client sur la même machine, c'est "
"pourquoi nous utilisons :code:`\"[: :]:8080\"`. Si nous exécutons une "
Expand Down Expand Up @@ -17225,8 +17221,8 @@ msgstr ""
#~ " and manages `virtual` clients. These "
#~ "clients are identical to `non-virtual`"
#~ " clients (i.e. the ones you launch"
#~ " via the command `flwr.client.start_numpy_client"
#~ " <ref-api-flwr.html#start-numpy-client>`_)"
#~ " via the command `flwr.client.start_client"
#~ " <ref-api-flwr.html#start-client>`_)"
#~ " in the sense that they can be"
#~ " configure by creating a class "
#~ "inheriting, for example, from "
Expand Down
12 changes: 5 additions & 7 deletions doc/locales/pt_BR/LC_MESSAGES/framework-docs.po
Original file line number Diff line number Diff line change
Expand Up @@ -2544,7 +2544,7 @@ msgid ""
"All that's left to do it to define a function that loads both model and "
"data, creates a :code:`CifarClient`, and starts this client. You load "
"your data and model by using :code:`cifar.py`. Start :code:`CifarClient` "
"with the function :code:`fl.client.start_numpy_client()` by pointing it "
"with the function :code:`fl.client.start_client()` by pointing it "
"at the same IP adress we used in :code:`server.py`:"
msgstr ""

Expand Down Expand Up @@ -4664,8 +4664,8 @@ msgstr ""
msgid ""
"The :code:`VirtualClientEngine` schedules, launches and manages `virtual`"
" clients. These clients are identical to `non-virtual` clients (i.e. the "
"ones you launch via the command `flwr.client.start_numpy_client <ref-api-"
"flwr.html#start-numpy-client>`_) in the sense that they can be configure "
"ones you launch via the command `flwr.client.start_client <ref-api-"
"flwr.html#start-client>`_) in the sense that they can be configure "
"by creating a class inheriting, for example, from "
"`flwr.client.NumPyClient <ref-api-flwr.html#flwr.client.NumPyClient>`_ "
"and therefore behave in an identical way. In addition to that, clients "
Expand Down Expand Up @@ -9719,8 +9719,7 @@ msgstr ""
#: ../../source/tutorial-quickstart-scikitlearn.rst:150
msgid ""
"That's it for the client. We only have to implement :code:`Client` or "
":code:`NumPyClient` and call :code:`fl.client.start_client()` or "
":code:`fl.client.start_numpy_client()`. The string "
":code:`NumPyClient` and call :code:`fl.client.start_client()`. The string "
":code:`\"0.0.0.0:8080\"` tells the client which server to connect to. In "
"our case we can run the server and the client on the same machine, "
"therefore we use :code:`\"0.0.0.0:8080\"`. If we run a truly federated "
Expand Down Expand Up @@ -9896,8 +9895,7 @@ msgstr ""
#: ../../source/tutorial-quickstart-tensorflow.rst:90
msgid ""
"That's it for the client. We only have to implement :code:`Client` or "
":code:`NumPyClient` and call :code:`fl.client.start_client()` or "
":code:`fl.client.start_numpy_client()`. The string :code:`\"[::]:8080\"` "
":code:`NumPyClient` and call :code:`fl.client.start_client()`. The string :code:`\"[::]:8080\"` "
"tells the client which server to connect to. In our case we can run the "
"server and the client on the same machine, therefore we use "
":code:`\"[::]:8080\"`. If we run a truly federated workload with the "
Expand Down
12 changes: 5 additions & 7 deletions doc/locales/zh_Hans/LC_MESSAGES/framework-docs.po
Original file line number Diff line number Diff line change
Expand Up @@ -2545,7 +2545,7 @@ msgid ""
"All that's left to do it to define a function that loads both model and "
"data, creates a :code:`CifarClient`, and starts this client. You load "
"your data and model by using :code:`cifar.py`. Start :code:`CifarClient` "
"with the function :code:`fl.client.start_numpy_client()` by pointing it "
"with the function :code:`fl.client.start_client()` by pointing it "
"at the same IP adress we used in :code:`server.py`:"
msgstr ""

Expand Down Expand Up @@ -4667,8 +4667,8 @@ msgstr ""
msgid ""
"The :code:`VirtualClientEngine` schedules, launches and manages `virtual`"
" clients. These clients are identical to `non-virtual` clients (i.e. the "
"ones you launch via the command `flwr.client.start_numpy_client <ref-api-"
"flwr.html#start-numpy-client>`_) in the sense that they can be configure "
"ones you launch via the command `flwr.client.start_client <ref-api-"
"flwr.html#start-client>`_) in the sense that they can be configure "
"by creating a class inheriting, for example, from "
"`flwr.client.NumPyClient <ref-api-flwr.html#flwr.client.NumPyClient>`_ "
"and therefore behave in an identical way. In addition to that, clients "
Expand Down Expand Up @@ -11011,8 +11011,7 @@ msgstr ""
#: ../../source/tutorial-quickstart-scikitlearn.rst:150
msgid ""
"That's it for the client. We only have to implement :code:`Client` or "
":code:`NumPyClient` and call :code:`fl.client.start_client()` or "
":code:`fl.client.start_numpy_client()`. The string "
":code:`NumPyClient` and call :code:`fl.client.start_client()`. The string "
":code:`\"0.0.0.0:8080\"` tells the client which server to connect to. In "
"our case we can run the server and the client on the same machine, "
"therefore we use :code:`\"0.0.0.0:8080\"`. If we run a truly federated "
Expand Down Expand Up @@ -11192,8 +11191,7 @@ msgstr ""
#: ../../source/tutorial-quickstart-tensorflow.rst:90
msgid ""
"That's it for the client. We only have to implement :code:`Client` or "
":code:`NumPyClient` and call :code:`fl.client.start_client()` or "
":code:`fl.client.start_numpy_client()`. The string :code:`\"[::]:8080\"` "
":code:`NumPyClient` and call :code:`fl.client.start_client()`. The string :code:`\"[::]:8080\"` "
"tells the client which server to connect to. In our case we can run the "
"server and the client on the same machine, therefore we use "
":code:`\"[::]:8080\"`. If we run a truly federated workload with the "
Expand Down
Loading