Create experimental mt-pytorch code example #1446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanertopal
reviewed
Oct 6, 2022
tanertopal
approved these changes
Oct 6, 2022
Comment on lines
+62
to
+76
| while True: | ||
| get_results_req = GetResultsRequest(task_ids=create_tasks_res.task_ids) | ||
|
|
||
| # ------------------------------------------------------------------ Driver SDK | ||
| get_results_res: GetResultsResponse = driver.get_results( | ||
| req=get_results_req | ||
| ) | ||
| # ------------------------------------------------------------------ Driver SDK | ||
|
|
||
| results: List[Result] = get_results_res.results | ||
| print(f"Got {len(get_results_res.results)} results") | ||
|
|
||
| all_results += results | ||
| if len(all_results) == len(task_ids): | ||
| break |
There was a problem hiding this comment.
@danieljanes We don't have an early stop here but as this is all experimental I am just noting my thoughts here :)
There was a problem hiding this comment.
Oh, also would be cool to use tqdm here too.
There was a problem hiding this comment.
I agree that these things would be cool, but my goal was more to create a minimal example here, which is why I'd suggest to keep is focussed :) regarding the early stopping, my assumption was that the server would enforce a timeout on all tasks anyways, so the driver can just wait until it gets either a full result or something that tells it that a particular task did not finish in time.
tanertopal
approved these changes
Oct 6, 2022
tanertopal
added a commit
that referenced
this pull request
Oct 30, 2022
* main: (21 commits) Create Flower tutorial part 3 (#1474) Update notebook tutorial (#1470) Fixed epoch_loss calculation in intro tutorial (#1472) Update notbook tutorials (#1468) Update README (#1465) Add DP docs to index (#1467) Support optional client methods in VCE (#1450) Implement Driver create_tasks and get_results (#1451) Update FED-0001 wording (#1464) Move client-side message handler into a separate package (#1462) Documentation for DP-FedAvg wrappers (#1460) Ray resources float (#1453) Slow down mt-pytorch code example, improve README (#1452) Update strategy sequence diagram (#1449) Update FedAvg documentation (#1417) Fix doc generation warnings (#1448) Create experimental mt-pytorch code example (#1446) Change case of file which was missed (#1447) Implement Driver get_clients (#1445) Implement Driver connect/disconnect (#1443) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.