ci: run linting and tests in different jobs #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
G-Rath
force-pushed
the
split-ci
branch
3 times, most recently
from
0238a78
to
ccf0212
Compare
|
Note that I've purposely used slightly outdated versions as I'm upgrading CI in #50 |
nzlaura
reviewed
Jun 19, 2024
| @@ -40,6 +51,6 @@ jobs: | |||
| with: | |||
| cache: 'npm' | |||
| - run: npm ci | |||
| - run: npm test | |||
There was a problem hiding this comment.
So you no longer need to run npm test 👀
There was a problem hiding this comment.
it's calling bin/ci-run, but actually I should remove the script from package.json since I've removed that file
nzlaura
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This splits our CI up into multiple jobs which is both faster and means we can test against Ruby 3.3 as the version of Rubocop we're using doesn't support that