Add support for --domain-controller option #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
March 7, 2019 10:38
Function validate_legacy, which is used in manifests/init.pp, was not implemented until 4.13.0.
Also implement default values if optional parameters are not set
Add rspec tests for leaving optional parameters empty
|
Thank you for finishing up this feature @Ekerhag, looks great and if I get some time I will look at getting the CI tests to pass again |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated puppet module to latest PDK version. This fixed config which made automatic tests on the module break (see files .gitlab-ci.yaml and .travisci and the line with "$RUBYGEMS_VERSION")
Added support for --domain-controller option. If empty we use the defaults from the domain, otherwise we use the one specified as a parameter.
Added rspec-tests for compiling the catalog with empty optional parameters.
Updated README with optional parameter and hiera examples.
The tests pass my gitlab-ci.yaml config, but I haven't figured out how to test TravisCI. It would be awesome if we could make the build field in the README say "pass" instead of "fail".