Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fish Tab Auto-completions #991

Merged
merged 3 commits into from
Jul 9, 2020

Conversation

OkeyDokeyGnocchi
Copy link
Contributor

  • Added the necessary complete.fish file for the tab auto-completes (based on the zsh and bash complete files)
  • Added the variables and fish completion loops in configure (copied the zsh ones and changed for fish)
  • Updated the Makefile to include the install and remove commands for creating the fish completions file

Built from source to test, all of the commands in complete.fish do autocomplete when using '-<tab>' and '--<tab>' and give the same list as bash. When using '-m' or '--monitor' it won't autocomplete '--synchronize' and vice-versa like in the bash version.

Created the set of auto-completes that Bash returns with '-<tab>' and '--<tab>'.  Made sure that --synchronize and -m/--monitor can't be used together based on the "#exclude some mutually exclusive options" in complete.bash file.
Add fish variables and checks to configure (mirroring zsh).
Add the FISH_COMPLETION_DIR variables and the install and remove instructions for the onedrive.fish completions file.
Copy link
Contributor

@SchoolGuy SchoolGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it on my machine manually. This works like a charm!

@abraunegg abraunegg self-requested a review July 9, 2020 06:03
@abraunegg
Copy link
Owner

@SchoolGuy
Thanks for testing and reviewing

@abraunegg abraunegg linked an issue Jul 9, 2020 that may be closed by this pull request
@abraunegg abraunegg merged commit 2b7e36d into abraunegg:master Jul 9, 2020
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators May 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fish Shell completition
3 participants