-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complete PR #78 #82
Complete PR #78 #82
Conversation
- Increasd buffer size for smoother progress handler calling
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amosavian Let's agree on the changes to make to this PR, and then I'll assign to you for review as I make the changes. I think that makes sense.
Let's not sweat the unit test failures right now. Some tests are failing because there are fewer progress updates than expected due to the buffer increasing. |
Thank you alot |
… updated unit tests to accommodate that new number
…file being extracted is a directory or not (Issue #74)
This is ready again for @amosavian to take a look. I updated the way directories are created and removed some dead code i discovered along the way. |
@amosavian Do you think you'll have a chance to take a look soon? Or should I go ahead and merge it in? |
I'm looking now thanks |
This branch contains @amosavian's changes from PR #78 applied to the
v1.9
branch. I'm going to review them here, and we'll make a squash merge to v1.9 with the changes made. If @amosavian likes to, he can create a PR against this branch, but it might get more confusing than it already is :-)