Extract OAuth 2.0 functionality #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodh
force-pushed
the
feature/openid4vci-draft-14
branch
2 times, most recently
from
8fe1533
to
512a206
Compare
nodh
force-pushed
the
feature/oauth2-service
branch
from
86ed5f7
to
572c100
Compare
...data-classes/src/commonMain/kotlin/at/asitplus/openid/SupportedCredentialFormatDefinition.kt
Show resolved
Hide resolved
vck-openid/src/commonMain/kotlin/at/asitplus/wallet/lib/oauth2/OAuth2Client.kt
Show resolved
Hide resolved
n0900
approved these changes
Sep 23, 2024
JesusMcCloud
approved these changes
Sep 25, 2024
nodh
force-pushed
the
feature/openid4vci-draft-14
branch
from
512a206
to
399105a
Compare
nodh
force-pushed
the
feature/oauth2-service
branch
from
07a5ccf
to
ec16cef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #130 it appeared to me we should extract more logic from OAuth 2.0 to decouple it from issuing, which should help with the ongoing work in #127