Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image and audio result focus rings #4959

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

obulat
Copy link
Contributor

@obulat obulat commented Sep 19, 2024

Fixes

Fixes #3525 by @fcoveram
Fixes #3193 by @fcoveram
Related to #4911 by @zackkrida

Description

This PR updates focus-bold-filled to set the inner ring to the color of the page background. It also updates the focus ring for the non-square image result.

The inner ring looks narrower in dark theme than it does in the light theme, so I updated the width for the dark theme.

Testing Instructions

Check the result focus rings for image, audio and all content results.
You can use the storybook to view image cell and the audio results

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (ov just catalog/generate-docs for catalog
    PRs) or the media properties generator (ov just catalog/generate-docs media-props
    for the catalog or ov just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@obulat obulat requested a review from a team as a code owner September 19, 2024 13:25
@obulat obulat mentioned this pull request Sep 19, 2024
6 tasks
@openverse-bot openverse-bot added 🧱 stack: documentation Related to Sphinx documentation 🧱 stack: frontend Related to the Nuxt frontend 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Sep 19, 2024
@obulat obulat force-pushed the fix/link-focus-rings branch 3 times, most recently from e9634bb to 4981994 Compare September 19, 2024 15:57
@obulat obulat marked this pull request as draft September 19, 2024 16:04
@obulat obulat force-pushed the fix/focus-bold-filled branch 2 times, most recently from 4a4b877 to faaf1e2 Compare September 19, 2024 18:13
@obulat obulat added ✨ goal: improvement Improvement to an existing user-facing feature 🕹 aspect: interface Concerns end-users' experience with the software 🟧 priority: high Stalls work on the project or its dependents and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Sep 19, 2024
@obulat obulat self-assigned this Sep 19, 2024
@obulat obulat force-pushed the fix/focus-bold-filled branch 2 times, most recently from 9fdf7a2 to e380c34 Compare September 19, 2024 18:53
@obulat obulat force-pushed the fix/focus-bold-filled branch 3 times, most recently from 64234b4 to 1688339 Compare September 19, 2024 20:22
@obulat obulat force-pushed the fix/focus-bold-filled branch 3 times, most recently from 09b24e1 to d973d08 Compare September 20, 2024 08:23
Copy link

Full-stack documentation: https://docs.openverse.org/_preview/4959

Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again.

You can check the GitHub pages deployment action list to see the current status of the deployments.

@obulat obulat marked this pull request as ready for review September 20, 2024 12:04
@obulat obulat changed the base branch from fix/link-focus-rings to main September 20, 2024 15:56
Copy link

Playwright failure test results: https://github.com/WordPress/openverse/actions/runs/10962448126

It looks like some of the Playwright tests failed. If you made changes to the frontend UI without updating snapshots, this might be the cause. You can download zipped patches containing the updated snapshots alongside a general trace of the tests under the "Artifacts" section in the above page. They're named in the form *_snapshot_diff and *_test_results respectively.

You can read more on how to use these artifacts in the docs.

If the test is flaky, follow the flaky test triage procedure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🕹 aspect: interface Concerns end-users' experience with the software ✨ goal: improvement Improvement to an existing user-facing feature 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: documentation Related to Sphinx documentation 🧱 stack: frontend Related to the Nuxt frontend
Projects
Status: 👀 Needs Review
Development

Successfully merging this pull request may close these issues.

Wrong focus style in image component Wrong focus style in image components
2 participants