-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix image and audio result focus rings #4959
base: main
Are you sure you want to change the base?
Conversation
e9634bb
to
4981994
Compare
4a4b877
to
faaf1e2
Compare
9fdf7a2
to
e380c34
Compare
2e8fbde
to
2a465ec
Compare
64234b4
to
1688339
Compare
2a465ec
to
ea74eb4
Compare
09b24e1
to
d973d08
Compare
Full-stack documentation: https://docs.openverse.org/_preview/4959 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. |
ea74eb4
to
9ee8226
Compare
d973d08
to
f55fbbb
Compare
Playwright failure test results: https://github.com/WordPress/openverse/actions/runs/10962448126 It looks like some of the Playwright tests failed. If you made changes to the frontend UI without updating snapshots, this might be the cause. You can download zipped patches containing the updated snapshots alongside a general trace of the tests under the "Artifacts" section in the above page. They're named in the form You can read more on how to use these artifacts in the docs. If the test is flaky, follow the flaky test triage procedure. |
Fixes
Fixes #3525 by @fcoveram
Fixes #3193 by @fcoveram
Related to #4911 by @zackkrida
Description
This PR updates
focus-bold-filled
to set the inner ring to the color of the page background. It also updates the focus ring for the non-square image result.The inner ring looks narrower in dark theme than it does in the light theme, so I updated the width for the dark theme.
Testing Instructions
Check the result focus rings for image, audio and all content results.
You can use the storybook to view image cell and the audio results
Checklist
Update index.md
).main
) or a parent feature branch.ov just catalog/generate-docs
for catalogPRs) or the media properties generator (
ov just catalog/generate-docs media-props
for the catalog or
ov just api/generate-docs
for the API) where applicable.Developer Certificate of Origin
Developer Certificate of Origin