-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support to Ruby 1.8.7 #3
Conversation
Forgot to say, httpi need this. 😄 |
@rogerleite Great. I will compile and test. 1.8.7 😰 Should be able to merge and release today. |
@rogerleite I am getting the following failures. Any ideas? https://gist.github.com/anonymous/5834186 OSX, ruby-1.8.7-p371 |
@pmorton this failures happened with me too. i don't know the "real" reason, after running I don't know if is related, i think if rspec bin points to another ruby, may cause this failures. A This weekend i'll be offline. |
@rogerleite can you pull 4b217f9 into this request. Lets see what travis has to say about it. I tried recompiling with rvm and and isolating the gemset and still no luck. For the moment if travis will pass, I will merge and release. which rspec shows that it is selecting /Users/pmorton/.rvm/gems/ruby-1.8.7-p371/bin/rspec... |
https://travis-ci.org/WinRb/rubyntlm/builds/8399654 don't know what is ... :/ |
I found the issue. There is some net/http magic that include ntlm. The test require 'net/ntlm' which leads to 1.8.7 aliasing the wrong method. |
Great news! Thanks for the new release. 🤘 |
Converted ntlm.rb to unix format.
Removed Gemfile.lock from git, explanation at http://yehudakatz.com/2010/12/16/clarifying-the-roles-of-the-gemspec-and-gemfile.
Based on 3f54039 commit, extracted EncodeUtil to define method, based on Ruby version.
I'm not sure if what i did on line rogerleite/rubyntlm@WinRb:master...support_to_ruby18#L4R41 is correct. Suggestions are welcome.