Changed ChatListener PostOrder to LATE #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WiIIiam278
approved these changes
Oct 17, 2023
There was a problem hiding this comment.
Yeah okay, the reason for this was to allow for other (punishment) plugins to do stuff, but it almost certainly shouldn't be set to LAST (you can tell I ported this pretty lazily from Bungee when I wrote the Velocity module, as I still have the unneeded startsWith('/') check in there. Might want to update this on the Bungee-side too. I'm guessing this affects SignedVelocity compatibility, so I'll merge shortly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.