fix[ImageCropper]: removeEventListener when destroyed(PanJiaChen#2169)

WangHui0306 · May 28, 2019 · a0793db · a0793db
1 parent 9538d1b
commit a0793db
Showing 1 changed file with 10 additions and 6 deletions.
diff --git a/src/components/ImageCropper/index.vue b/src/components/ImageCropper/index.vue
@@ -839,16 +839,20 @@ export default {
           that.$emit('crop-upload-fail', err, field, ki)
         }
       })
+    },
+    closeHandler(e) {
+      if (this.value && (e.key == 'Escape' || e.keyCode == 27)) {
+        this.off()
+      }
     }
   },
   created() {
     // 绑定按键esc隐藏此插件事件
-    document.addEventListener('keyup', (e) => {
-      if (this.value && (e.key == 'Escape' || e.keyCode == 27)) {
-        this.off()
-      }
-    })
-  }
+    document.addEventListener('keyup', this.closeHandler)
+  },
+  destroyed() {
+    document.removeEventListener('keyup', this.closeHandler)
+  },
 }
 </script>