fix: avoid deeplinking if document isn't in focus #5229

ganchoradkov · 2024-07-30T12:50:04Z

Description

Avoid deeplinking if document is not in focus. This resolves an issue where deeplinks initiated when app was in background would trigger when the app is back in focus leading to confusing behaviour

Type of change

Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Draft PR (breaking/non-breaking change which needs more work for having a proper functionality [Mark this PR as ready to review only when completely ready])
Breaking change (fix or feature that would cause existing functionality to not work as expected)

How has this been tested?

canary 2.15.2-canary-9bbce7c

Checklist

I have performed a self-review of my own code
My changes generate no new warnings
Any dependent changes have been merged and published in downstream modules

Additional Information (Optional)

Please include any additional information that may be useful for the reviewer.

arein

this is a bit more risky. Are we sure there's no edge cases where the browser is in background and then comes to the foreground shortly after?

Cali93

Can we add unit tests for the function and cover this case ? 🙏

Cali93 · 2024-07-30T13:35:13Z

packages/utils/src/misc.ts

@@ -379,6 +379,11 @@ export async function handleDeeplinkRedirect({
    const env = getEnvironment();

    if (env === ENV_MAP.browser) {
+      if (!getDocument()?.hasFocus()) {
+        console.warn("Document does not have focus, skipping deeplink.");


I think no log or just console.log would be more appropriate since this is the expected behaviour.

…^2.16.0 (#5951) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@walletconnect/react-native-compat](https://redirect.github.com/walletconnect/walletconnect-monorepo) | [`^2.15.2` -> `^2.16.0`](https://renovatebot.com/diffs/npm/@walletconnect%2freact-native-compat/2.15.2/2.16.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@walletconnect%2freact-native-compat/2.16.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@walletconnect%2freact-native-compat/2.16.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@walletconnect%2freact-native-compat/2.15.2/2.16.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@walletconnect%2freact-native-compat/2.15.2/2.16.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>walletconnect/walletconnect-monorepo (@walletconnect/react-native-compat)</summary> ### [`v2.16.0`](https://redirect.github.com/WalletConnect/walletconnect-monorepo/releases/tag/2.16.0) [Compare Source](https://redirect.github.com/walletconnect/walletconnect-monorepo/compare/2.15.3...2.16.0) #### What's Changed - chore: prep for 2.15.3 release by [@ganchoradkov](https://redirect.github.com/ganchoradkov) in [WalletConnect/walletconnect-monorepo#5331 - feat: link mode by [@ignaciosantise](https://redirect.github.com/ignaciosantise) in [WalletConnect/walletconnect-monorepo#5141 **Full Changelog**: WalletConnect/walletconnect-monorepo@2.15.3...2.16.0 ### [`v2.15.3`](https://redirect.github.com/WalletConnect/walletconnect-monorepo/releases/tag/2.15.3) [Compare Source](https://redirect.github.com/walletconnect/walletconnect-monorepo/compare/2.15.2...2.15.3) #### What's Changed - chore: prep for `2.15.2` release by [@ganchoradkov](https://redirect.github.com/ganchoradkov) in [WalletConnect/walletconnect-monorepo#5319 - Fix getVerifyContext when onSessionAuthenticateRequest by [@quetool](https://redirect.github.com/quetool) in [WalletConnect/walletconnect-monorepo#5324 - fix: avoid deeplinking if document isn't in focus by [@ganchoradkov](https://redirect.github.com/ganchoradkov) in [WalletConnect/walletconnect-monorepo#5229 - fix: enforces origin url to be verified to produce verify context by [@ganchoradkov](https://redirect.github.com/ganchoradkov) in [WalletConnect/walletconnect-monorepo#5327 - feat: auto publish to npm by [@ganchoradkov](https://redirect.github.com/ganchoradkov) in [WalletConnect/walletconnect-monorepo#5202 **Full Changelog**: WalletConnect/walletconnect-monorepo@2.15.2...2.15.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone America/Los_Angeles. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/valora-inc/wallet).  --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: valora-bot <[email protected]>

This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@walletconnect/utils](https://redirect.github.com/walletconnect/walletconnect-monorepo) | [`^2.15.2` -> `^2.16.0`](https://renovatebot.com/diffs/npm/@walletconnect%2futils/2.15.2/2.16.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@walletconnect%2futils/2.16.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@walletconnect%2futils/2.16.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@walletconnect%2futils/2.15.2/2.16.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@walletconnect%2futils/2.15.2/2.16.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>walletconnect/walletconnect-monorepo (@walletconnect/utils)</summary> ### [`v2.16.0`](https://redirect.github.com/WalletConnect/walletconnect-monorepo/releases/tag/2.16.0) [Compare Source](https://redirect.github.com/walletconnect/walletconnect-monorepo/compare/2.15.3...2.16.0) #### What's Changed - chore: prep for 2.15.3 release by [@ganchoradkov](https://redirect.github.com/ganchoradkov) in [WalletConnect/walletconnect-monorepo#5331 - feat: link mode by [@ignaciosantise](https://redirect.github.com/ignaciosantise) in [WalletConnect/walletconnect-monorepo#5141 **Full Changelog**: WalletConnect/walletconnect-monorepo@2.15.3...2.16.0 ### [`v2.15.3`](https://redirect.github.com/WalletConnect/walletconnect-monorepo/releases/tag/2.15.3) [Compare Source](https://redirect.github.com/walletconnect/walletconnect-monorepo/compare/2.15.2...2.15.3) #### What's Changed - chore: prep for `2.15.2` release by [@ganchoradkov](https://redirect.github.com/ganchoradkov) in [WalletConnect/walletconnect-monorepo#5319 - Fix getVerifyContext when onSessionAuthenticateRequest by [@quetool](https://redirect.github.com/quetool) in [WalletConnect/walletconnect-monorepo#5324 - fix: avoid deeplinking if document isn't in focus by [@ganchoradkov](https://redirect.github.com/ganchoradkov) in [WalletConnect/walletconnect-monorepo#5229 - fix: enforces origin url to be verified to produce verify context by [@ganchoradkov](https://redirect.github.com/ganchoradkov) in [WalletConnect/walletconnect-monorepo#5327 - feat: auto publish to npm by [@ganchoradkov](https://redirect.github.com/ganchoradkov) in [WalletConnect/walletconnect-monorepo#5202 **Full Changelog**: WalletConnect/walletconnect-monorepo@2.15.2...2.15.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone America/Los_Angeles. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/valora-inc/wallet).  --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Jean Regisser <[email protected]>

fix: avoid deeplinking if document isn't in focus

be88bb9

ganchoradkov requested a review from lukaisailovic July 30, 2024 12:50

arein added the accepted label Jul 30, 2024

ganchoradkov requested a review from ignaciosantise July 30, 2024 12:50

arein reviewed Jul 30, 2024

View reviewed changes

Cali93 approved these changes Jul 30, 2024

View reviewed changes

ganchoradkov mentioned this pull request Jul 31, 2024

feat: disable deeplink redirection flag #5223

Closed

8 tasks

ganchoradkov added 3 commits August 12, 2024 15:50

Merge branch 'v2.0' into fix/deeplink-on-background-apps

75b4efe

Merge branch 'v2.0' into fix/deeplink-on-background-apps

0f3cbce

Merge branch 'v2.0' into fix/deeplink-on-background-apps

91c5876

ganchoradkov merged commit 18697af into v2.0 Sep 4, 2024
3 checks passed

ganchoradkov deleted the fix/deeplink-on-background-apps branch September 4, 2024 11:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: avoid deeplinking if document isn't in focus #5229

fix: avoid deeplinking if document isn't in focus #5229

ganchoradkov commented Jul 30, 2024 •

edited

Loading

arein left a comment

Cali93 left a comment

Cali93 Jul 30, 2024

fix: avoid deeplinking if document isn't in focus #5229

fix: avoid deeplinking if document isn't in focus #5229

Conversation

ganchoradkov commented Jul 30, 2024 • edited Loading

Description

Type of change

How has this been tested?

Checklist

Additional Information (Optional)

arein left a comment

Choose a reason for hiding this comment

Cali93 left a comment

Choose a reason for hiding this comment

Cali93 Jul 30, 2024

Choose a reason for hiding this comment

ganchoradkov commented Jul 30, 2024 •

edited

Loading