Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(utils): remove dependency on query-string and dedupe uint8arrays #5104

Open
wants to merge 12 commits into
base: v2.0
Choose a base branch
from

Conversation

talentlessguy
Copy link
Contributor

@talentlessguy talentlessguy commented Jun 29, 2024

Description

This PR removes usage of query-string in utils and replaces them with a widely available URLSearchParams. It also dedupes download of uint8arrays (currently it pulls 3.1.0 and 3.1.1 etc)

Related: es-tooling/ecosystem-cleanup#10

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Draft PR (breaking/non-breaking change which needs more work for having a proper functionality [Mark this PR as ready to review only when completely ready])
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How has this been tested?

Through unit tests

Checklist

  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@glitch-txs glitch-txs requested review from ganchoradkov and removed request for glitch-txs July 19, 2024 11:17
@talentlessguy
Copy link
Contributor Author

@ganchoradkov besides the lockfile, is there anything else that needs to be fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants