-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(utils): remove dependency on query-string and dedupe uint8arrays #5104
Open
talentlessguy
wants to merge
12
commits into
WalletConnect:v2.0
Choose a base branch
from
talentlessguy:rm-query-string-dedupe-u8arrays
base: v2.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix(utils): remove dependency on query-string and dedupe uint8arrays #5104
talentlessguy
wants to merge
12
commits into
WalletConnect:v2.0
from
talentlessguy:rm-query-string-dedupe-u8arrays
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glitch-txs
reviewed
Jun 29, 2024
8 tasks
…-monorepo into rm-query-string-dedupe-u8arrays
glitch-txs
requested review from
ganchoradkov
and removed request for
glitch-txs
July 19, 2024 11:17
…-monorepo into rm-query-string-dedupe-u8arrays
glitch-txs
reviewed
Aug 15, 2024
Co-authored-by: Glitch <[email protected]>
@ganchoradkov besides the lockfile, is there anything else that needs to be fixed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes usage of query-string in utils and replaces them with a widely available URLSearchParams. It also dedupes download of uint8arrays (currently it pulls 3.1.0 and 3.1.1 etc)
Related: es-tooling/ecosystem-cleanup#10
Type of change
How has this been tested?
Through unit tests
Checklist