Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow hash in URL #727

Merged
merged 3 commits into from
Oct 20, 2021
Merged

Allow hash in URL #727

merged 3 commits into from
Oct 20, 2021

Conversation

v3rm0n
Copy link
Contributor

@v3rm0n v3rm0n commented Sep 16, 2021

Ini parser considers hash as an inline comment and removes it. Instead
we configure the parser to only consider hash an inline comment when it
is preceded by a space.

An example where this is useful: when you add a Custom SAML Application to AWS SSO you can't use the normal aws sso login process to get your credentials, you need to use something like saml2aws, currently in browser mode. Problem with browser mode is that AWS SSO page will open links in a new tab so playwright won't find the correct redirect since it happens in another tab.

So I figured out two solutions:

  • Make Playwright listen to popup redirects as well
  • Open the link straight away

Since the link is actually just the SSO page with appended hash (which triggers a POST), I need to add the hash to the URL which currently doesn't work because the INI parsers thinks it's a comment.

v3rm0n and others added 3 commits September 16, 2021 14:57
Ini parser considers hash as an inline comment and removes it. Instead
we configure the parser to only consider hash an inline comment when it
is preceded by a space.
@wolfeidau wolfeidau merged commit 8c1b6fe into Versent:master Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants