Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚡️ Optimize DynamicArrayLib #1084

Merged
merged 3 commits into from
Sep 19, 2024
Merged

⚡️ Optimize DynamicArrayLib #1084

merged 3 commits into from
Sep 19, 2024

Conversation

Vectorized
Copy link
Owner

Description

⚡️

Checklist

Ensure you completed all of the steps below before submitting your pull request:

  • Ran forge fmt?
  • Ran forge test?

Pull requests with an incomplete checklist will be thrown out.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 18, 2024 •
edited
Loading

Gas Snapshot Comparison Report

Generated at commit : dd33f2c, Compared to commit : 0234e7d

Contract Name Test Name Main Gas PR Gas Diff
DeploylessPredeployQueryerTest testTargetGenerate() 360733 367539 6806
DynamicArrayLibTest testDynamicArrayPushAfterReserve() 39934 40001 67
test__codesize() 8005 8362 357
DynamicBufferLibTest testDynamicBufferReserveFromEmpty2() 2441 2429 -12
test__codesize() 14840 14832 -8
DynamicArrayLibTest testUint256ArrayPopulate() - 17057 -
testUint256ArrayPopulateOriginal() - 22825 -

@Vectorized Vectorized merged commit 8f3d6ce into main Sep 19, 2024
14 checks passed
@Vectorized Vectorized deleted the dal-opt branch September 19, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Vectorized