Fix #486 - when you log off on a ship and it moves, you should log on still in the ship, not in the middle of nowhere #937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
m-doescode
force-pushed
the
1.20.1/feature/teleport-reconnected-players
branch
from
ac068a1
to
666446b
Compare
ewoudje
requested changes
Aug 11, 2024
.../valkyrienskies/mod/mixin/feature/teleport_reconnected_player_to_ship/MixinServerPlayer.java
Outdated
Show resolved
Hide resolved
… reconnected player teleportation to be disabled
xiewuzhiying
pushed a commit
to xiewuzhiying/Valkyrien-Skies-2
that referenced
this pull request
Aug 28, 2024
… should log on still in the ship, not in the middle of nowhere (ValkyrienSkies#937) * Added basic implementation of teleporting disconnected players back onto ships * Removed print statements * Extracted MAX_ONBOARD_TICKS from magic number * Moved MAX_ONBOARD_TICKS to a config option, and added the ability for reconnected player teleportation to be disabled --------- Authored-by: m-doescode <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #486
When you log off on top of a ship, or in mid-air within 4 ticks of jumping off a ship (can be changed), the id of the last ship you stood on, as well as your position in the ship's chunk claim is saved as nbt. When you reconnect, and you have the
LastShipIdtag, and it points to a valid ship, then the chunk claim position is translated to the world position and you are teleported to that position.Please let me know of any errors/considerations. Thank you.