Replaced assembly code by M_Marvin (Ported to Kotlin/Multiloader by PriestOfFern) #854
+273
−187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should probably rename everything with contraption in it to ship. It's a left over from marvin's code, which calls VS2 ships contraptions for some reason Also so you can probably just remove triggerBlockChange() since it's just calling updateBlock() |
1 task
ewoudje
reviewed
Aug 15, 2024
|
|
||
| fun updateBlock(level: Level, fromPos: BlockPos, toPos: BlockPos, toState: BlockState) { | ||
|
|
||
| // 75 = flag 1 (block update) & flag 2 (send to clients) + flag 8 (force rerenders) |
There was a problem hiding this comment.
Why does it say 75 =, when its 11 and also flag 8 has a + instead of a &
There was a problem hiding this comment.
ewou, this PR is outdated. Tomato added the assembly code while they were adding vs-api to 1.18
|
Close it then... |
|
@ewoudje do I look like I have PR perms |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self Explanatory
Might need some review
Didn't want to remove the old assembly functions as to not break existing addons so I deprecated them for now
Should also be able to handle assembling ships out of ships supposedly, unable to test rn while I redo splitting