Skip to content

Commit

Permalink
added placement and forceUpdate in useEffect dependency
Browse files Browse the repository at this point in the history
  • Loading branch information
amars29 committed Dec 3, 2020
1 parent 5a90e90 commit c4b239e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/PluginStore.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export class PluginStore {
const installedNameAndVer = this.getInstalledPluginNameWithVersion(
depName
);
const [installedName, installedVersion] = installedNameAndVer
const [, installedVersion] = installedNameAndVer
? installedNameAndVer.split('@')
: [null, ''];
if (!installedNameAndVer) {
Expand Down
2 changes: 1 addition & 1 deletion src/plugins/RendererPlugin/components/Renderer.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export const Renderer: React.SFC<{
eventListener
);
};
}, [pluginStore]);
}, [pluginStore, placement, forceUpdate]);

let components = pluginStore.executeFunction(
'Renderer.getComponentsInPosition',
Expand Down

0 comments on commit c4b239e

Please sign in to comment.