2.6.2 - Fix JsonShopConfiguration saves #157
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KillerOfPie
approved these changes
Oct 8, 2023
…re performant master-queue-only impl based on ConcurrentSkipListSet.This was tested by me and seemed to be working, let's see what the testers say...
- Added save validation that checks for excess '{' or '}' and attempts to re-save with them removed
- There is a good chance this will not properly load existing shop data. To prevent this from affecting servers that haven't confirmed, the Message Prefix setting in the config will need to START with `§a§b§2§3§6§1`
- There is a good chance this will not properly load existing shop data. To prevent this from affecting servers that haven't confirmed, the Message Prefix setting in the config will need to START with `§a§b§2§c§6§1`
- There is a good chance this will not properly load existing shop data. To prevent this from affecting servers that haven't confirmed, the Message Prefix setting in the config will need to START with `§a§f§2§c§6§1`
- There is a good chance this will not properly load existing shop data. To prevent this from affecting servers that haven't confirmed, the Message Prefix setting in the config will need to START with `§a§7§2§c§6§1`
- There is a good chance this will not properly load existing shop data. To prevent this from affecting servers that haven't confirmed, the Message Prefix setting in the config will need to START with `§a§7§2§c§6§6`
- There is a good chance this will not properly load existing shop data. To prevent this from affecting servers that haven't confirmed, the Message Prefix setting in the config will need to START with `§a§7§1§c§6§6`
- There is a good chance this will not properly load existing shop data. To prevent this from affecting servers that haven't confirmed, the Message Prefix setting in the config will need to START with `§a§7§1§2§f§6`
- There is a good chance this will not properly load existing shop data. To prevent this from affecting servers that haven't confirmed, the Message Prefix setting in the config will need to START with `§a§7§1§2§f§6`
- There is a good chance this will not properly load existing shop data. To prevent this from affecting servers that haven't confirmed, the Message Prefix setting in the config will need to START with `§a§7§1§2§f§6`
- There is a good chance this will not properly load existing shop data. To prevent this from affecting servers that haven't confirmed, the Message Prefix setting in the config will need to START with `§a§7§6§2§f§6`
- There is a good chance this will not properly load existing shop data. To prevent this from affecting servers that haven't confirmed, the Message Prefix setting in the config will need to START with `§a§3§6§2§f§6`
- There is a good chance this will not properly load existing shop data. To prevent this from affecting servers that haven't confirmed, the Message Prefix setting in the config will need to START with `§a§3§c§2§f§6`
- There is a good chance this will not properly load existing shop data. To prevent this from affecting servers that haven't confirmed, the Message Prefix setting in the config will need to START with `§a§3§c§2§f§6`
Pie's PTSD
- Should also fix unwanted Debug
- fox for findchest npe - fix for concurrentmod exception
- Fix for missing config # - Removed FileCache from JsonConfiguration
|
Will this get merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Etiquette
There are several guidelines you should follow in order for your Pull Request to be merged.
Replace
[ ]with[x]to cross the checkbox.Changes
Fix for bug reported on discord about shop deletion not being saved/reflected in save files. Also introduces a thread (task) pool system for better performance. The previous async saving implementation relying on HashMaps as semaphores/locks was only a band-aid fix.
I have done some basic testing with 1-2 threads, more stress-testing (more queued save jobs, more threads) would be helpful.