Make everything even more minimallistic

TopherEllis · Apr 9, 2021 · 0a2e18c · 0a2e18c
1 parent c639492
commit 0a2e18c
Show file tree

Hide file tree

Showing 7 changed files with 35 additions and 84 deletions.
diff --git a/README.md b/README.md
@@ -1,6 +1,6 @@
 # electron-boilerplate
 
-A minimalistic boilerplate for [Electron runtime](https://www.electronjs.org/). Tested on Windows, macOS and Linux.  
+Minimalistic, very easy to understand boilerplate for [Electron runtime](https://www.electronjs.org/). Tested on Windows, macOS and Linux.  
 
 This project contains only bare minimum of tooling and dependencies to provide you with simple to understand and extensible base (but still, this is fully functional Electron environment). The boilerplate doesn't impose on you any frontend technologies, so feel free to pick your favourite.
 

diff --git a/app/app.html b/app/app.html
@@ -1,27 +1,24 @@
-<!doctype html>
+<!DOCTYPE html>
 <html>
-<head>
-  <meta charset="utf-8">
-  <title>Electron Boilerplate</title>
-</head>
-<body>
+  <head>
+    <meta charset="utf-8" />
+    <title>Electron Boilerplate</title>
+  </head>
+  <body>
+    <div id="app" class="container" style="display: none;">
+      <h1 id="greet"></h1>
+      <p>
+        Welcome to
+        <a href="https://www.electronjs.org/" class="electron-website-link">
+          Electron
+        </a>
+        app running on this <strong id="os"></strong> machine.
+      </p>
+      <p>App author: <strong id="author"></strong></p>
+      <p>Environment: <strong id="env"></strong></p>
+      <p>Electron version: <strong id="electron-version"></strong></p>
+    </div>
 
-  <div id="app" class="container" style="display: none;">
-    <h1 id="greet"></h1>
-    <p>
-      Welcome to <a href="https://www.electronjs.org/" class="js-external-link">Electron</a> app running on this <strong id="os"></strong> machine.
-    </p>
-    <p>
-      App author: <strong id="author"></strong>
-    </p>
-    <p>
-      Environment: <strong id="env"></strong>
-    </p>
-    <p>
-      Electron version: <strong id="electron-version"></strong>
-    </p>
-  </div>
-
-  <script src="app.js"></script>
-</body>
+    <script src="app.js"></script>
+  </body>
 </html>
diff --git a/package.json b/package.json
@@ -31,7 +31,6 @@
     "release": "npm test && webpack --config=build/webpack.app.config.js --env=production && electron-builder"
   },
   "dependencies": {
-    "electron-context-menu": "^2.5.0",
     "fs-jetpack": "^4.1.0"
   },
   "devDependencies": {

diff --git a/src/app.js b/src/app.js
@@ -1,11 +1,6 @@
 import "./stylesheets/main.css";
 
-// Small helper you might want to keep
-import "./helpers/external_links_renderer.js";
-
-// ----------------------------------------------------------------------------
 // Everything below is just a demo. You can delete all of it.
-// ----------------------------------------------------------------------------
 
 import { ipcRenderer } from "electron";
 import jetpack from "fs-jetpack";
@@ -34,3 +29,12 @@ ipcRenderer.on("app-path", (event, appDirPath) => {
   document.querySelector("#author").innerHTML = manifest.author;
 });
 ipcRenderer.send("need-app-path");
+
+document.querySelector(".electron-website-link").addEventListener(
+  "click",
+  event => {
+    ipcRenderer.send("open-external-link", event.target.href);
+    event.preventDefault();
+  },
+  false
+);
diff --git a/src/helpers/external_links.js b/src/helpers/external_links.js
diff --git a/src/helpers/external_links_renderer.js b/src/helpers/external_links_renderer.js
diff --git a/src/main.js b/src/main.js
@@ -5,12 +5,10 @@
 
 import path from "path";
 import url from "url";
-import contextMenu from "electron-context-menu";
-import { app, Menu, ipcMain } from "electron";
+import { app, Menu, ipcMain, shell } from "electron";
 import appMenuTemplate from "./menu/app_menu_template";
 import editMenuTemplate from "./menu/edit_menu_template";
 import devMenuTemplate from "./menu/dev_menu_template";
-import externalLinks from "./helpers/external_links";
 import createWindow from "./helpers/window";
 
 // Special module holding environment variables which you declared
@@ -38,11 +36,11 @@ const initIpc = () => {
   ipcMain.on("need-app-path", (event, arg) => {
     event.reply("app-path", app.getAppPath());
   });
+  ipcMain.on("open-external-link", (event, href) => {
+    shell.openExternal(href);
+  });
 };
 
-contextMenu();
-externalLinks();
-
 app.on("ready", () => {
   setApplicationMenu();
   initIpc();