Arc-trigo and other math functions refurbished

include/eve/module/math/pedantic/math.hpp

@@ -7,9 +7,8 @@
 //==================================================================================================
 #pragma once
 
-#include <eve/module/math/pedantic/atan2.hpp>
-#include <eve/module/math/pedantic/atan2d.hpp>
-#include <eve/module/math/pedantic/atan2pi.hpp>
+// #include <eve/module/math/pedantic/atan2d.hpp>
+// #include <eve/module/math/pedantic/atan2pi.hpp>
 #include <eve/module/math/pedantic/horner.hpp>
 #include <eve/module/math/pedantic/lpnorm.hpp>
 #include <eve/module/math/pedantic/reverse_horner.hpp>

include/eve/module/math/regular/acosd.hpp

@@ -15,14 +15,14 @@
 
 namespace eve
 {
-template<typename Options>
-struct acosd_t : elementwise_callable<acosd_t, Options, raw_option>
-{
-  template<eve::floating_ordered_value T>
-  constexpr EVE_FORCEINLINE T operator()(T v) const  { return EVE_DISPATCH_CALL(v); }
+  template<typename Options>
+  struct acosd_t : elementwise_callable<acosd_t, Options, raw_option>
+  {
+    template<eve::floating_ordered_value T>
+    constexpr EVE_FORCEINLINE T operator()(T v) const  { return EVE_DISPATCH_CALL(v); }
 
-  EVE_CALLABLE_OBJECT(acosd_t, acosd_);
-};
+    EVE_CALLABLE_OBJECT(acosd_t, acosd_);
+  };
 //================================================================================================
 //! @addtogroup math_invtrig
 //! @{
@@ -66,15 +66,14 @@ struct acosd_t : elementwise_callable<acosd_t, Options, raw_option>
 //!  @godbolt{doc/math/regular/acosd.cpp}
 //!  @}
 //================================================================================================
-inline constexpr auto acosd = functor<acosd_t>;
+  inline constexpr auto acosd = functor<acosd_t>;
 
-namespace detail
-{
-  template<typename T, callable_options O>
-  constexpr EVE_FORCEINLINE T acosd_(EVE_REQUIRES(cpu_), O const& o, T const& a0)
+  namespace detail
   {
-    if constexpr( has_native_abi_v<T> ) return radindeg(acos[o](a0));
-    else                                return apply_over(acosd[o], a0);
+    template<typename T, callable_options O>
+    constexpr EVE_FORCEINLINE T acosd_(EVE_REQUIRES(cpu_), O const& o, T const& a0)
+    {
+      return radindeg(acos[o](a0));
+    }
   }
 }
-}

include/eve/module/math/regular/acosh.hpp

@@ -7,10 +7,26 @@
 //==================================================================================================
 #pragma once
 
-#include <eve/detail/overload.hpp>
+#include <eve/arch.hpp>
+#include <eve/traits/overload.hpp>
+#include <eve/module/core/decorator/core.hpp>
+#include <eve/module/core.hpp>
+#include <eve/module/math/constant/inv_2eps.hpp>
+#include <eve/module/math/constant/log_2.hpp>
+#include <eve/module/math/regular/log.hpp>
+#include <eve/module/math/regular/log1p.hpp>
 
 namespace eve
 {
+  template<typename Options>
+  struct acosh_t : elementwise_callable<acosh_t, Options>
+  {
+    template<eve::floating_ordered_value T>
+    constexpr EVE_FORCEINLINE T operator()(T v) const  { return EVE_DISPATCH_CALL(v); }
+
+    EVE_CALLABLE_OBJECT(acosh_t, acosh_);
+};
+
 //================================================================================================
 //! @addtogroup math_invhyper
 //! @{
@@ -50,22 +66,33 @@ namespace eve
 //!      * If the element is \f$1\f$, \f$+0\f$ is returned.
 //!      * If the element is \f$+\infty\f$, \f$+\infty\f$ is returned.
 //!      * If the element is a `Nan`, `NaN` is returned.
-//!  
+//!
 //!  @groupheader{Example}
 //!
 //!  @godbolt{doc/math/regular/acosh.cpp}
 //!
 //!  @}
 //================================================================================================
-namespace tag
-{
-  struct acosh_;
-}
+  inline constexpr auto acosh = functor<acosh_t>;
 
-template<> struct supports_optimized_conversion<tag::acosh_> : std::true_type
-{};
+  namespace detail
+  {
+    template<typename T, callable_options O>
+    constexpr EVE_FORCEINLINE T acosh_(EVE_REQUIRES(cpu_), O const&, T const& x)
+    {
+      const T    t    = dec(x);
+      auto const test = is_greater(t, inv_2eps(eve::as<T>()));
 
-EVE_MAKE_CALLABLE(acosh_, acosh);
+      if constexpr( simd_value<T> )
+      {
+        const T z = if_else(test, x, t + sqrt(fma(t, t, t + t)));
+        return add[test](log1p(z), log_2(eve::as<T>()));
+      }
+      else if constexpr( scalar_value<T> )
+      {
+        if( test ) { return eve::log(t) + log_2(eve::as<T>()); }
+        else { return eve::log1p(t + eve::sqrt(fma(t, t, t + t))); }
+      }
+    }
+  }
 }
-
-#include <eve/module/math/regular/impl/acosh.hpp>

include/eve/module/math/regular/acot.hpp

@@ -7,10 +7,23 @@
 //==================================================================================================
 #pragma once
 
-#include <eve/detail/overload.hpp>
+#include <eve/arch.hpp>
+#include <eve/traits/overload.hpp>
+#include <eve/module/core/decorator/core.hpp>
+#include <eve/module/core.hpp>
+#include <eve/module/math/detail/generic/atan_kernel.hpp>
 
 namespace eve
 {
+  template<typename Options>
+  struct acot_t : elementwise_callable<acot_t, Options>
+  {
+    template<eve::floating_ordered_value T>
+    constexpr EVE_FORCEINLINE T operator()(T v) const  { return EVE_DISPATCH_CALL(v); }
+
+    EVE_CALLABLE_OBJECT(acot_t, acot_);
+};
+
 //================================================================================================
 //! @addtogroup math_invtrig
 //! @{
@@ -53,8 +66,20 @@ namespace eve
 //!  @godbolt{doc/math/regular/acot.cpp}
 //!  @}
 //================================================================================================
+  inline constexpr auto acot = functor<acot_t>;
 
-EVE_MAKE_CALLABLE(acot_, acot);
+  namespace detail
+  {
+    template<typename T, callable_options O>
+    constexpr EVE_FORCEINLINE T acot_(EVE_REQUIRES(cpu_), O const&, T const& a)
+    {
+      if constexpr( has_native_abi_v<T> )
+      {
+        auto x = eve::abs(a);
+        return bit_xor(atan_kernel(rec(x), x), bitofsign(a));
+      }
+      else
+        return apply_over(acot, a);
+    }
+  }
 }
-
-#include <eve/module/math/regular/impl/acot.hpp>

include/eve/module/math/regular/acotd.hpp

@@ -7,10 +7,21 @@
 //==================================================================================================
 #pragma once
 
-#include <eve/detail/overload.hpp>
+#include <eve/arch.hpp>
+#include <eve/traits/overload.hpp>
+#include <eve/module/core/decorator/core.hpp>
 
 namespace eve
 {
+  template<typename Options>
+  struct acotd_t : elementwise_callable<acotd_t, Options>
+  {
+    template<eve::floating_ordered_value T>
+    constexpr EVE_FORCEINLINE T operator()(T v) const  { return EVE_DISPATCH_CALL(v); }
+
+    EVE_CALLABLE_OBJECT(acotd_t, acotd_);
+};
+
 //================================================================================================
 //! @addtogroup math_invtrig
 //! @{
@@ -56,8 +67,14 @@ namespace eve
 //!  @godbolt{doc/math/regular/acotd.cpp}
 //!  @}
 //================================================================================================
+  inline constexpr auto acotd = functor<acotd_t>;
 
-EVE_MAKE_CALLABLE(acotd_, acotd);
+  namespace detail
+  {
+    template<typename T, callable_options O>
+    constexpr EVE_FORCEINLINE T acotd_(EVE_REQUIRES(cpu_), O const&, T const& a)
+    {
+      return radindeg(acot(a));
+    }
+  }
 }
-
-#include <eve/module/math/regular/impl/acotd.hpp>