-
-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zoom_enhance makes no changes to image in 8.3.1 #134
Comments
Looking at line 345 of zoom_enhance.py:
I do have controlnet installed, but the issue persists even if I don't use it. I'll try disabling. |
Disabling controlnet has no effect. |
Turning debug on, it gets all the way to this line:
So it doesn't seem to be raising an exception. |
Two other things I should probably mention:
|
If it helps, this is an issue even if you don't have ControlNet installed. |
Hi @ratsark, Thank you for reaching out! I haven't been able to reproduce this issue yet. After turning A few other diagnostic questions:
Hope we can get to the bottom of it! |
Hi, I just released a big update--Unprompted v9.0.0--with a lot of fixes and improvements. It may or may not resolve the issue you've been having with |
it persists for me |
Hi @R3dPhil (as well as anyone else who is still having trouble with zoom_enhance), Please provide any error messages in your console as well as answers to these diagnostic questions to help me identify the cause. Thank you! |
@ThereforeGames there are no error messages in console for zoom enhance. It just doesn't do anything in A1111 latest build. |
I can't seem to get zoom_enhance working either. I'm a bit new to SD so might just be my fault, but to answer your diagnostic questions:
I'm attaching the output, no errors, but it doesn't seem to be finishing (or maybe it's supposed to look like this?). Running debug I see all the pictures generated in the webui folder and the zoomed in faces do show up in the img2img folder. show_original doesn't seem to be doing anything either. |
Hi folks, I have pushed a new version of First, here's the image we're going for:
I want you to run the following prompt with the new
Check your console for errors after each generation. If you get an error, you'll need to restart the UI before trying the next one. For this test, please also make sure you meet the following conditions:
Finally, please look in your WebUI folder for the new debug image Thank you for your help. |
Ran the tests, it never successfully placed the updated image in the txt2img directory, but it did create a successful final result image with the debug in 4/6 tests. It's just not putting them back where the original came from.
|
Thank you, @Fenwich. That at least narrows the problem down to the I just pushed a small update with a couple extra sanity checks. Could you let me know if it makes a difference? You can disable the I appreciate your patience with this. It's a tough thing to debug as I still haven't been able to reproduce the issue on any of my devices. |
I appreciate your patience working with us on this and fast responses! Unfortunately, it looks like that didn't fix anything. I still see the original image in my txt2img-images folder (for reference, mine is at "D:\Stable Diffusion\stable-diffusion-webui\outputs\txt2img-images\2023-04-29\00000-1.png"). I see the updated face in my img2img-images folder, "D:\Stable Diffusion\stable-diffusion-webui\outputs\img2img-images\2023-04-29\00000-1.png". And, I still see the zoom_enhance_final_result created successfully in the stable-diffusion-webui folder. |
Hmm. Alright, I'm attaching another file you can try - replace the existing If it still doesn't work, look for an error in your console to the effect of, Also, I have a couple more diagnostic questions:
Thanks! |
I'm using Chrome. I have installed ControlNet but I haven't really done any playing with it, so I'm not sure how much help I can be with what works or doesn't work on that front. Still didn't work, but I did get "after_processed var is: [<PIL.Image.Image image mode=RGB size=512x512 at 0x22512E67850>]" |
i am using firefox. control net is disabled. testing in txt2img. sometimes it writes the files into webui, sometimes it doesn't. the most perplexing thing is that i tried the line File "E:\SD2023_05\stable-diffusion-webui\modules\scripts.py", line 436, in postprocess by the way, an earlier version works fine that i have in another folder with an earlier version of stable diffusion. that one has the original control net. the outputs go to the temp folder, but they look good. this is an awesome extension. i love the modular nature of it. i'm really hoping to get great hands and faces with this, unfortunately i am using the batch on control net, so i need to use the current one. thanks for all your work on this. EDIT: still working on it. it definitely is remembering previous terms. i will try that file replacement you mentioned earlier EDIT: okay, i switched to the new file you mentioned 2 posts above. |
GOOD NEWS, EVERYONE! |
It works singly with control net, saving the correct image to the temp folder. it does not work with control net batch. in neither circumstance does it save the correct image to the image output folder. |
Newest version actually breaks more things (with newest auto version as well) No errors in console |
Last time extension was able to provide stitched image (altough now its doing the masking wrong, faces dont seem to align no clue why) |
thanks Dawgmastah for that info, i will give that a shot. the brand new pull i got today is working great with everything, but i haven't tried the stitching yet. it is working with controlnet, the block code logic is solid. |
Oh wow, wish it worked with me :( |
Yup can't get this extension to work anymore; trying with versions 7.8 - 7.9.1 as the new upscaler method is horrible |
I just tried a full reinstall with only the unprompted extension, and still the issue persists on my machine (Ubuntu under WSL). @ThereforeGames is there any other diagnostic information that would be helpful? I'll try to find some time to debug it in more depth. |
Digging into the code I noticed the test flag, which I somehow missed in the discussion above. Tests 3, 4, and 5 all work for me, and show the edited result in the window. |
In the latest commit (8.3.1), zoom_enhance will run img2img jobs (visible in the server logs) but doesn't affect the output images. This issue is not present in 8.3.0 (or the immediately-following fix, 7bae7f8), verified via
git reset <sha> && git stash
.I'm using
show_original
to get a side-by-side comparison, anduse_workaround
seems to have no effect.The text was updated successfully, but these errors were encountered: