Skip to content

Commit

Permalink
remove hard-coded version strings
Browse files Browse the repository at this point in the history
  • Loading branch information
jon gadsden committed Sep 8, 2022
1 parent 48ce6b6 commit 65981de
Show file tree
Hide file tree
Showing 10 changed files with 25 additions and 2,631 deletions.
2 changes: 1 addition & 1 deletion ThreatDragonModels/v2-new-model.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"version": "2.0",
"version": "2.0.0",
"summary": {
"title":"New threat model"
},
Expand Down
10 changes: 6 additions & 4 deletions td.vue/src/service/demo/index.js
Original file line number Diff line number Diff line change
@@ -1,11 +1,13 @@
import newThreatModel from './new-model.js';
import demoThreatModel from './demo-threat-model.js';
import v2NewModel from './v2-new-model.js';
import v2ThreatModel from './v2-threat-model.js';
import v2NewThreaModel from './v2-new-model.js';
import v2DemoThreatModel from './v2-threat-model.js';

const models = [
{ name: 'New Model', model: newThreatModel },
{ name: 'Demo Threat Model', model: demoThreatModel },
{ name: 'Version 2 New Model', model: v2NewModel },
{ name: 'Version 2 Demo Model', model: v2ThreatModel }
{ name: 'Version 2 New Model', model: v2NewThreaModel },
{ name: 'Version 2 Demo Model', model: v2DemoThreatModel }
];

export default {
Expand Down
897 changes: 0 additions & 897 deletions td.vue/src/service/demo/legacy-desktop-model.js

This file was deleted.

769 changes: 0 additions & 769 deletions td.vue/src/service/demo/legacy-model-2.js

This file was deleted.

952 changes: 0 additions & 952 deletions td.vue/src/service/demo/legacy-model.js

This file was deleted.

10 changes: 10 additions & 0 deletions td.vue/src/service/demo/new-model.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
export default{
'version': '1.6.1',
'summary': {
'title':'New threat model'
},
'detail': {
'contributors': [],
'diagrams': []
}
};
3 changes: 1 addition & 2 deletions td.vue/src/service/demo/v2-new-model.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
export default{
'tdVersion': '2.0',
'version': '2.0.0',
'summary': {
'title': 'New Threat Model',
'owner': '',
Expand All @@ -12,4 +12,3 @@ export default{
'reviewer': ''
}
};

4 changes: 2 additions & 2 deletions td.vue/src/service/migration/diagram.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,14 @@ const drawV1 = (diagram, graph) => {
};

const upgradeAndDraw = (diagram, graph) => {
if (diagram.version === '2.0') {
if (diagram.version != null && diagram.version.startsWith('2.')) {
graph.fromJSON(diagram);
return;
}

drawV1(diagram, graph);
const updated = graph.toJSON();
updated.version = '2.0';
updated.version = store.packageBuildVersion;
updated.title = diagram.title;
updated.thumbnail = diagram.thumbnail;
updated.id = diagram.id;
Expand Down
2 changes: 1 addition & 1 deletion td.vue/src/store/modules/threatmodel.js
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ const getters = {
return contribs.map(x => x.name);
},
modelChanged: (state) => JSON.stringify(state.data) !== state.immutableCopy,
isV1Model: (state) => Object.keys(state.data).length > 0 && state.data.version !== '2.0'
isV1Model: (state) => Object.keys(state.data).length > 0 && (state.data.version == null || state.data.version.startsWith('1.'))
};

export default {
Expand Down
7 changes: 4 additions & 3 deletions td.vue/src/views/NewThreatModel.vue
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,13 @@ import tmActions from '@/store/actions/threatmodel.js';
export default {
name: 'NewThreatModel',
computed: mapState({
providerType: state => getProviderType(state.provider.selected)
providerType: state => getProviderType(state.provider.selected),
version: 'packageBuildVersion'
}),
mounted() {
this.$store.dispatch(tmActions.clear);
const newTm = {
version: '2.0',
version: this.version,
summary: {
title: 'New Threat Model',
owner: '',
Expand All @@ -29,7 +30,7 @@ export default {
reviewer: ''
}
};
this.$store.dispatch(tmActions.selected, newTm);
const params = Object.assign({}, this.$route.params, {
threatmodel: newTm.summary.title
Expand Down

0 comments on commit 65981de

Please sign in to comment.