Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add my project #8229

Merged
merged 2 commits into from
Aug 27, 2018
Merged

Add my project #8229

merged 2 commits into from
Aug 27, 2018

Conversation

CristinaAP
Copy link
Contributor

This is a PR template. If you are adding a solution link to the curriculum, leave this as is. If not, delete it and write the message you wish.

Thank you,

The Odin Project team.

@@ -94,6 +94,7 @@ There are a couple of ways to go about doing this, but the simplest is this:
Submit a pull request with a link to your solution in this [file](https://github.com/TheOdinProject/curriculum/edit/master/web_development_101/project_html_css.md) when your project is complete. See the section on [Contributing](http://github.com/TheOdinProject/curriculum/blob/master/contributing.md) for how.

* Add your solution below this list
* [Cristina Popescu's Solution (Easy)](https://cristinaap.github.io/google-homepage) - [View in browser](https://cristinaap.github.io/google-homepage/)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your first link should be to the github repository your project exists in so others can read your code and learn from it. Can you fix this? Then I'll merge it :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, i changed the link and made a new pull request. Sorry...first time doing this :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok...saw afterwards that I can make the change directly...

@CouchofTomato CouchofTomato merged commit bd7ecdc into TheOdinProject:master Aug 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants