Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

octal_to_decimal converter #2399

Merged
merged 3 commits into from
Sep 10, 2020
Merged

octal_to_decimal converter #2399

merged 3 commits into from
Sep 10, 2020

Conversation

mohammadreza490
Copy link
Contributor

octal to decimal converter

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@mohammadreza490
Copy link
Contributor Author

@cclauss Hey, can you please review my last 2 pull requests?
Thanks

cclauss
cclauss approved these changes Sep 10, 2020
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your submission.

@cclauss cclauss merged commit 696cd47 into TheAlgorithms:master Sep 10, 2020
@cybov cybov mentioned this pull request Oct 12, 2020
Closed
14 tasks
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@mohammadreza490 @cclauss @stokhos
octal_to_decimal converter (TheAlgorithms#2399)
df97663 
* Create octal_to_decimal

octal to decimal converter

* Update octal_to_decimal

* Update conversions/octal_to_decimal

Co-authored-by: Christian Clauss <[email protected]>

Co-authored-by: Christian Clauss <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mohammadreza490 @cclauss