Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Replace Swap and Comparison Methods with SortUtils Utility Methods #5246

Merged
merged 2 commits into from
Jun 22, 2024

Conversation

alxkm
Copy link
Contributor

@alxkm alxkm commented Jun 22, 2024

The HeapSort class had duplicated methods for less and swap, which already exist in SortUtils.

It is better to use the common methods instead of the old ones.

This pull request also includes some renaming for clarity.

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.70%. Comparing base (e8f1990) to head (112aabd).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5246      +/-   ##
============================================
- Coverage     39.71%   39.70%   -0.02%     
+ Complexity     2433     2430       -3     
============================================
  Files           517      517              
  Lines         15496    15492       -4     
  Branches       2958     2958              
============================================
- Hits           6155     6151       -4     
  Misses         9052     9052              
  Partials        289      289              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vil02 vil02 merged commit 308bdcf into TheAlgorithms:master Jun 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants