Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Combination #5225

Closed
wants to merge 13 commits into from
Prev Previous commit
Next Next commit
fix pmd
  • Loading branch information
Samuel Facchinello committed Jun 12, 2024
commit f5d72aa9a40293369c3743367edd5bde0ea37832
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please:

  • add a test case with data being an empty array and combinationSize being positive,
  • add a test case with data being an empty array and combinationSize being zero,
  • add a test case with data being [1, 2, 3] and combinationSize being 2,
  • add a test case with data being an array of strings.

Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertNull;
import static org.junit.jupiter.api.Assertions.assertTrue;

import java.util.List;
samuelfac marked this conversation as resolved.
Show resolved Hide resolved
import java.util.TreeSet;
Expand Down