Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cpp fixes] tidied up code based on error reports by clang-tidy #950

Merged
merged 3 commits into from
Jul 13, 2020
Merged

[cpp fixes] tidied up code based on error reports by clang-tidy #950

merged 3 commits into from
Jul 13, 2020

Conversation

kvedala
Copy link
Collaborator

@kvedala kvedala commented Jul 12, 2020 •
edited by gitpod-io bot
Loading

Description of Change

tidied up code based on error reports by clang-tidy

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:

@kvedala kvedala requested a review from ayaankhan98 July 12, 2020 21:57
ayaankhan98
ayaankhan98 reviewed Jul 13, 2020
View reviewed changes
machine_learning/adaline_learning.cpp
@@ -35,7 +36,8 @@
#include <numeric>
#include <vector>

#define MAX_ITER 500 // INT_MAX ///< Maximum number of iterations to learn
/** Maximum number of iterations to learn */
constexpr int MAX_ITER = 500; // INT_MAX
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

ayaankhan98
ayaankhan98 approved these changes Jul 13, 2020
View reviewed changes
Copy link
Member

@ayaankhan98 ayaankhan98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kvedala kvedala merged commit 8ab9a2a into TheAlgorithms:master Jul 13, 2020
@kvedala kvedala deleted the cpp-standard branch July 13, 2020 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayaankhan98 ayaankhan98 ayaankhan98 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kvedala @ayaankhan98