-
-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quadratic equations complex numbers #2451
Quadratic equations complex numbers #2451
Conversation
This reverts commit a1433a9.
docs: Changed comment style
docs: added documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there!
…com/Renjian-buchai/C-Plus-Plus into Quadratic-Equations-Complex-Numbers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I think Panquesito7 or another maintainer has to review for this to be integrated. Thank you for your contribution! 🙂
Thanks for reviewing! Your help is greatly appreciated. 😄 |
Co-authored-by: realstealthninja <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome. Thanks! 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments - almost all of them are non-blocking so I'm approving for now.
…com/Renjian-buchai/C-Plus-Plus into Quadratic-Equations-Complex-Numbers
d89ee9d
Co-authored-by: Taj <[email protected]>
Co-authored-by: Taj <[email protected]>
Co-authored-by: Taj <[email protected]>
Description of Change
Added quadratic_equations_complex_numbers.cpp that computes both real and complex quadratic roots.
Checklist
Notes: Quadratic equation solver with complex roots added, incl. test cases & demonstration.