Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quadratic equations complex numbers #2451

Merged
merged 23 commits into from
Apr 28, 2023
Merged

Quadratic equations complex numbers #2451

merged 23 commits into from
Apr 28, 2023

Conversation

Renjian-buchai
Copy link
Contributor

Description of Change

Added quadratic_equations_complex_numbers.cpp that computes both real and complex quadratic roots.

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • Relevant documentation/comments is changed or added
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes: Quadratic equation solver with complex roots added, incl. test cases & demonstration.

math/quadratic_equations_complex_numbers.cpp Outdated Show resolved Hide resolved
math/quadratic_equations_complex_numbers.cpp Show resolved Hide resolved
math/quadratic_equations_complex_numbers.cpp Outdated Show resolved Hide resolved
math/quadratic_equations_complex_numbers.cpp Show resolved Hide resolved
math/quadratic_equations_complex_numbers.cpp Outdated Show resolved Hide resolved
math/quadratic_equations_complex_numbers.cpp Outdated Show resolved Hide resolved
math/quadratic_equations_complex_numbers.cpp Outdated Show resolved Hide resolved
math/quadratic_equations_complex_numbers.cpp Outdated Show resolved Hide resolved
math/quadratic_equations_complex_numbers.cpp Outdated Show resolved Hide resolved
Copy link
Collaborator

@realstealthninja realstealthninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there!

math/quadratic_equations_complex_numbers.cpp Outdated Show resolved Hide resolved
math/quadratic_equations_complex_numbers.cpp Show resolved Hide resolved
math/quadratic_equations_complex_numbers.cpp Show resolved Hide resolved
Copy link
Collaborator

@realstealthninja realstealthninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I think Panquesito7 or another maintainer has to review for this to be integrated. Thank you for your contribution! 🙂

math/quadratic_equations_complex_numbers.cpp Outdated Show resolved Hide resolved
@Panquesito7
Copy link
Member

Looks good to me

Thanks for reviewing! Your help is greatly appreciated. 😄

@Panquesito7 Panquesito7 added the enhancement New feature or request label Apr 26, 2023
math/quadratic_equations_complex_numbers.cpp Outdated Show resolved Hide resolved
math/quadratic_equations_complex_numbers.cpp Outdated Show resolved Hide resolved
math/quadratic_equations_complex_numbers.cpp Show resolved Hide resolved
math/quadratic_equations_complex_numbers.cpp Show resolved Hide resolved
math/quadratic_equations_complex_numbers.cpp Outdated Show resolved Hide resolved
math/quadratic_equations_complex_numbers.cpp Outdated Show resolved Hide resolved
math/quadratic_equations_complex_numbers.cpp Outdated Show resolved Hide resolved
math/quadratic_equations_complex_numbers.cpp Outdated Show resolved Hide resolved
@Panquesito7 Panquesito7 added automated tests are failing Do not merge until tests pass enhancement New feature or request and removed enhancement New feature or request labels Apr 26, 2023
@Panquesito7 Panquesito7 removed the automated tests are failing Do not merge until tests pass label Apr 26, 2023
Panquesito7
Panquesito7 previously approved these changes Apr 27, 2023
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thanks! 🚀

Copy link
Collaborator

@realstealthninja realstealthninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

tjgurwara99
tjgurwara99 previously approved these changes Apr 28, 2023
Copy link
Member

@tjgurwara99 tjgurwara99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments - almost all of them are non-blocking so I'm approving for now.

math/quadratic_equations_complex_numbers.cpp Show resolved Hide resolved
math/quadratic_equations_complex_numbers.cpp Outdated Show resolved Hide resolved
math/quadratic_equations_complex_numbers.cpp Show resolved Hide resolved
@Panquesito7 Panquesito7 merged commit a022701 into TheAlgorithms:master Apr 28, 2023
@Renjian-buchai Renjian-buchai deleted the Quadratic-Equations-Complex-Numbers branch April 29, 2023 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants