Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fit euler's totient to the contribution guidelines. #2447

Merged
merged 13 commits into from
Apr 28, 2023
Merged

fix: fit euler's totient to the contribution guidelines. #2447

merged 13 commits into from
Apr 28, 2023

Conversation

realstealthninja
Copy link
Collaborator

Description of Change

Made some minor adjustment to the algorithm itself
by inverting the if statement.
Removed an unneccessary include.
Added tests.

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes: Matched guidelines

@Panquesito7 Panquesito7 added the Improvement improvement in previously written codes label Apr 14, 2023
Panquesito7
Panquesito7 requested changes Apr 14, 2023
View reviewed changes
math/eulers_totient_function.cpp Outdated Show resolved Hide resolved
math/eulers_totient_function.cpp Outdated Show resolved Hide resolved
math/eulers_totient_function.cpp Outdated Show resolved Hide resolved
math/eulers_totient_function.cpp Show resolved Hide resolved
Panquesito7
Panquesito7 reviewed Apr 21, 2023
View reviewed changes
math/eulers_totient_function.cpp Outdated Show resolved Hide resolved
math/eulers_totient_function.cpp Outdated Show resolved Hide resolved
Panquesito7
Panquesito7 reviewed Apr 26, 2023
View reviewed changes
math/eulers_totient_function.cpp Outdated Show resolved Hide resolved
math/eulers_totient_function.cpp Show resolved Hide resolved
Panquesito7
Panquesito7 approved these changes Apr 26, 2023
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thanks! 🚀

@Panquesito7 Panquesito7 merged commit 4b740d4 into TheAlgorithms:master Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjgurwara99 tjgurwara99 tjgurwara99 approved these changes

@Panquesito7 Panquesito7 Panquesito7 approved these changes

Assignees
No one assigned
Labels
Improvement improvement in previously written codes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@realstealthninja @tjgurwara99 @Panquesito7